-
Notifications
You must be signed in to change notification settings - Fork 47
feat(lgshadow): update drop shadow to new design #1503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lgshadow): update drop shadow to new design #1503
Conversation
elenagarrone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Thank you 🙏
owensgit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @ashB100, just a tiny suggestion from me
Xinchro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
|
🎉 This PR is included in version 13.0.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Canopy lgShadow directive added a box-shadow to its host component. However, the box-shadow value was from an older design. Canopy designs has a new desgin for drop shadows. Navigation cards already has the updated drop shadow styles. However, it hardcodes the value in .lg-card--navigation class.
This PR:
--drop-shadowCSS custom property the latest Canopy design box-shadow value--box-shadow-hoverand sets its value to the latest Canopy drop shadow hover state value--drop-shadowCSS custom property, instead of hardcoding it in the class.box-shadow: var(--drop-shadow);--box-shadow-hoverCSS custom property, instead of hardcoding it in the class.box-shadow: var(--drop-shadow-hover);hasHoverStateinput toLgShadowDirective. Users can opt in to add a hover state drop shadow to their component (typically a card), by setting thehasHoverState.hasHoverStateinput inLgShadowDirectiveShadowPromotionsFixes # (issue)
Requirements
Please briefly outline any requirements for the work which may aid the testing and review process.
Design link: (link to design or delete if not required)
Screenshot: (if appropriate provide a quick screen grab of the changes)
Checklist: