-
Notifications
You must be signed in to change notification settings - Fork 47
Next #1652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next #1652
Conversation
BREAKING CHANGE: Spacing and layout variables have been updated, spacing directives require new values, --space-unit and xs breakpoint removed
BREAKING CHANGE: the placeholder has been removed as it was causing a11y issues. We have added the hint component instead. This is added automatically to the codebase. Any existing hints used within the date field will not appear anymore.
BREAKING CHANGE: the placeholder has been removed as it was causing a11y issues. You will need to manually add an `lg-hint` component as per the example in the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request implements a comprehensive spacing and layout modernization as part of BM (Brand Modernization) updates. The changes migrate from a named spacing system (xxxs through xxxxl) to a numbered token system (1-10), introduce new CSS design tokens, update breakpoints, and remove placeholder text from form fields to improve accessibility.
Key changes:
- Migration from named spacing variables (--space-xxxs, --space-sm, etc.) to numbered tokens (--space-1, --space-4, etc.)
- Introduction of responsive spacing tokens that vary by breakpoint (sm/md vs lg/xl/xxl)
- Breakpoint changes:
smstarts at 0 instead of 20rem, removal ofxsbreakpoint - Removal of placeholder text from date and sort code inputs for better accessibility
- Modernization of Angular templates from
*ngIf/*ngForto@if/@forcontrol flow syntax
Reviewed changes
Copilot reviewed 209 out of 209 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/generate-css-variables.js | Extended script to process both variables and tokens directories, with improved error handling |
| projects/canopy/src/styles/tokens/*.css | New CSS token files with comprehensive design token definitions |
| projects/canopy/src/styles/spacing.scss | Complete rewrite using responsive token system instead of fixed spacing values |
| projects/canopy/src/styles/mixins.scss | Updated sm breakpoint from 20rem to 0 |
| Multiple component SCSS files | Updated spacing references from named to numbered system (e.g., --space-sm to --space-4) |
| projects/canopy/src/lib/forms/date/* | Removed placeholder text and migrated hint to component template for consistency |
| projects/canopy/src/lib/forms/sort-code/* | Removed placeholder attribute from directive |
| projects/canopy/src/lib/grid/* | Removed xs breakpoint support, migrated to sm as minimum |
| Multiple story files | Migrated Angular templates to new control flow syntax |
| Test files | Updated expectations to match new spacing values and removed unnecessary imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Migration guide
|
|
🎉 This PR is included in version 19.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Includes updates to the spacing and layout as part of the BM updates.
Update to remove the spaceholder text on sort code and date field
Checklist: