Basic pert250319 #282
Open
Basic pert250319 #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main changes are in: 1. get_toggles(): perturbation: yes/no/auto 2. Modify calc_frac.cpp, PertEngine.cpp, perturbation.cpp to introduce perturbation_per_image() and perturbation_per_pixel() 3. Use g_use_perturbation to control perturbation flow within calc_frac.cpp
Changes: 1. Update cmdfiles.cpp to allow reading batch files with perturbation fractals 2. Clean up frasetup.cpp and fractalb.cpp to remove unnecessary code for perturbation 3. Simplify PertEngine.cpp to only accept initial reference 4. Symmetry, filters etc now work through standard_calc()
Added Perturbation to info screen
…ay.cpp for perturbation 1. Read and write perturbation to par files 2. Display perturbation and number of references These need to be merged into master so we have a standard for users rather than using plot type = 'p'
|
Youve got two open pull requests that appear to be identical; please close one of them. |
|
How did I do that? It surely wasn't intentional. |
|
Probably just accidentally clicked the button twice or something. No big deal. |
|
No worries |
|
The first step in getting these pull requests to green builds is to get them rebased onto master. |
|
There have been so many commits since these pull requests were made that it is probably best to close these ones and start again from pulling down the current master and adding changes from there. Then we can create a new pull request and rebase from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't completed getting perturbation to work within standard_fractal() but there are a number of files that can be merged so we have a standard way of using Id with perturbation.
The following files can be merged so we have a standard IO and display as well as batch file operation that includes perturbation:
make_batch_file.cpp, cmdfiles.cpp, get_toggles.cpp, tab_display.cpp
Currently in this branch, perturbation only uses a single reference pixel and only renders correctly if that pixel is at the highest iteration count in the image. Getting additional reference pixels is daunting without further nodification to Standard_fractal() as the iteration count needs to be reset after adding a reference. I'm not sure how to get around this. Maybe some offline discussion will help.