Skip to content

calculateItemsInView - Don't return early if sticky index changed #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MPiccinato wants to merge 1 commit into
base: main
Choose a base branch
from
Open

calculateItemsInView - Don't return early if sticky index changed #381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/core/calculateItemsInView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,9 @@ export function calculateItemsInView(
const currentStickyIdx =
stickyIndicesArr.length > 0 ? findCurrentStickyIndex(stickyIndicesArr, scroll, state) : -1;
const nextActiveStickyIndex = currentStickyIdx >= 0 ? stickyIndicesArr[currentStickyIdx] : undefined;
const stickyIndexDidChange = previousStickyIndex !== nextActiveStickyIndex;
state.activeStickyIndex = nextActiveStickyIndex;

let scrollBufferTop = scrollBuffer;
let scrollBufferBottom = scrollBuffer;

Expand All @@ -213,7 +214,7 @@ export function calculateItemsInView(
const scrollBottomBuffered = scrollBottom + scrollBufferBottom;

// Check precomputed scroll range to see if we can skip this check
if (!dataChanged && scrollForNextCalculateItemsInView) {
if (!dataChanged && !stickyIndexDidChange && scrollForNextCalculateItemsInView) {
const { top, bottom } = scrollForNextCalculateItemsInView;
if (scrollTopBuffered > top && scrollBottomBuffered < bottom) {
return;
Expand Down