fix(indexeddb): close stale db on versionchange#640
Open
Shervanator wants to merge 1 commit intoLegendApp:mainfrom
Open
fix(indexeddb): close stale db on versionchange#640Shervanator wants to merge 1 commit intoLegendApp:mainfrom
Shervanator wants to merge 1 commit intoLegendApp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves IndexedDB upgrade diagnostics and adds the standard connection-handling hook for version changes.
Changes
openRequest.onblockedlogging duringindexedDB.open(...).db.onversionchangehandling after open success and close the stale DB connection.Motivation
During app deploys that bump IndexedDB version, some clients can get stuck if upgrade coordination across browser contexts fails. This change follows IndexedDB best practices for cross-context upgrades and improves observability when upgrade contention occurs.
Problem
ObservablePersistIndexedDB.initialize()currently opens the DB and handles upgrade/create, but it does not:onblocked, orversionchangeis signaled.Both can make upgrade issues difficult to diagnose and increase the risk of blocked migrations.
Why This Change
onversionchange -> db.close()is the recommended IndexedDB pattern so old contexts release locks when a newer version is opening.onblockedlogging provides immediate visibility into upgrade contention.Scope / Compatibility
onblockedoronversionchange.Request for Reviewers
If maintainers have a reliable multi-tab/version-upgrade repro harness, please validate:
versionchangeand closes.