(fix) #641 unsubscribe Not Triggered with syncObservable#642
Open
msantang78 wants to merge 1 commit intoLegendApp:mainfrom
Open
(fix) #641 unsubscribe Not Triggered with syncObservable#642msantang78 wants to merge 1 commit intoLegendApp:mainfrom
msantang78 wants to merge 1 commit intoLegendApp:mainfrom
Conversation
msantang78
force-pushed
the
fix/unsubscribe-syncObservable-641
branch
2 times, most recently
from
185da64 to
17192e1
Compare
msantang78
force-pushed
the
fix/unsubscribe-syncObservable-641
branch
from
17192e1 to
5f9fe4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves #641
The synced observables created by
syncObservablewere not marked as synced, so the previous fix that I did for #621 was not working in this case.