Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am main developer of Daedalus Compiler https://github.com/dzieje-khorinis/DaedalusCompiler and we would prefer to support more strict syntax of Daedalus than original compiler. We prefer not to use keywords like
class,instance,varas identifiers (names of variables, attributes, functions, parameters etc.). We also do not like syntax:var int x, var int y;instead we would like to change it tovar int x; var int y;(We also currently supportvar int x, y;). Also, we don't like single expression return hacks (because it's abusing the engine) but since it's essential to use in Ikarus & Lego, we allowed having lines likeexpression;. These lines give warnings tough (errors in--strictmode). However we implemented special comments to suppress these warnings. They have syntax like this://suppress: WARNING_CODE [ WARNING_CODE]*and can be used to suppress warnings with selected codes for whole file (if this comment is in first line of file) or can be used to suppress warnings per line like this:Our compiler already successfully compiles Gothic2NotR and Basic Ikarus&Lego project. Results (
.datfiles) are the same as generated by original compiler. Here's TestCase proving that: https://github.com/dzieje-khorinis/DaedalusCompiler/blob/master/test/DaedalusCompiler.Tests/OutputComparisonTests.csThe reason for this PR is because we would like to make Ikarus & LeGo compatible with our compiler.