Aesthetic and Correctness changes in code ready for publication #1
Open
facusapienza21 wants to merge 5 commits intoLenGallo:masterfrom
Open
Aesthetic and Correctness changes in code ready for publication #1facusapienza21 wants to merge 5 commits intoLenGallo:masterfrom
facusapienza21 wants to merge 5 commits intoLenGallo:masterfrom
Conversation
…Some code is now in auxiliar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small changes in code. Mostly changes in how the code and the different sections were organized. Some of the functions were moved to auxiliary scripts. I left the function declaration for the last section in
APWP.ipynbbut ideally, all these functions should be included in an auxiliary file. Added more description to README, we should test if external members can actually clone and run the code with the virtual environment we provide.