Open
Conversation
JosuaKrause
commented
Aug 10, 2012
JosuaKrause
commented
- (almost) full test coverage (at least everything that makes sense)
- direct baked array sequence for faster creation when no changes are made
- extended the interfaces a bit
- methods from maps are named more like their java.util.Map counterparts
- iteration over maps (keys, values, entries)
- maps now allow null keys and values
- the class Persistent is an easy way to create PersistentSequences without worrying about which classes to use
- AbstractPersistentMap to create other implementations
- there is no way to ensure empty sequences/maps though -- got to solve that problem :)
more test coverage
simplified equality of persistent entries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.