Fix packet leak bug #81
Open
+50
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank your for the PR! This is going in an interesting direction. However, the NAMED_ENTITY_SPAWN packet has changed several times since 1.7, so it is probably not going to work on older versions. Perhaps we need to make it e.g. a 1.20+ feature. Also currently this only checks the sv.see permission but does not account for layered permissions (sv.see.levelX, sv.use.levelX). |
Contributor
Author
|
I've fixed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a player logs in, they receive a
NAMED_ENTITY_SPAWNpacket for all players around them, even vanished players. This allows players using appropriate mods to know if there are vanished players around them.This PR solves this problem by blocking the packet if the player is vanished.