Skip to content

fix: address CodeRabbit review findings from PR #203 #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bedatty merged 1 commit into from
Apr 6, 2026
+1 −11
Merged

fix: address CodeRabbit review findings from PR #203 #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .cursor/rules/reusable-workflows.mdc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,15 +146,6 @@ on:
secrets:
DEPLOY_TOKEN:
required: true
workflow_dispatch:
inputs:
environment:
required: true
type: string
dry_run:
description: Preview changes without applying them
type: boolean
default: false
```

The two modes have opposite goals — design them accordingly:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gitops-update.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ jobs:
exit 1
fi

BACKOFF=$((i * 2))
BACKOFF=$((2 ** i))
echo "Push failed (attempt $i/$MAX_RETRIES), rebasing and retrying in ${BACKOFF}s..."
sleep "$BACKOFF"
git pull --rebase origin main
Expand Down
1 change: 0 additions & 1 deletion docs/build-workflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ Generated tags based on semantic versioning:
| Tag Pattern | Example | When Applied |
|-------------|---------|--------------|
| `{{version}}` | `1.0.0-beta.1` | Always |
| `{{major}}.{{minor}}` | `1.0` | Always |
| `{{major}}` | `1` | Release tags only |

## Monorepo Change Detection
Expand Down
Loading