Skip to content

Limit count queries to 500 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Discordius wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Limit count queries to 500 #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/vulcan-core/lib/modules/default_resolvers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { createError } from 'apollo-errors';

const defaultOptions = {
cacheMaxAge: 300,
maxCountQuery: 500
};

// note: for some reason changing resolverOptions to "options" throws error
Expand Down Expand Up @@ -80,7 +81,7 @@ export function getDefaultResolvers(options) {

if (enableTotal) {
// get total count of documents matching the selector
data.totalCount = await Connectors.count(collection, selector);
data.totalCount = await Connectors.count(collection, selector, {limit: resolverOptions.maxCountQuery});
}

// return results
Expand Down
2 changes: 1 addition & 1 deletion packages/vulcan-lib/lib/server/connectors/mongo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ DatabaseConnectors.mongo = {
return await collection.find(convertSelector(selector), options).fetch();
},
count: async (collection, selector = {}, options = {}) => {
return await collection.find(convertSelector(selector), options).count();
return await collection.find(convertSelector(selector), options).count(options);
},
create: async (collection, document, options = {}) => {
return await collection.insert(document);
Expand Down