Skip to content

Comments

Action Schema#3

Open
madeofstars0 wants to merge 8 commits intoLessig2016:masterfrom
8bitduck:master
Open

Action Schema#3
madeofstars0 wants to merge 8 commits intoLessig2016:masterfrom
8bitduck:master

Conversation

@madeofstars0
Copy link

No description provided.

@aschober
Copy link
Contributor

👍

@madeofstars0
Copy link
Author

furf [11:40 AM]
looking over the schema

furf [11:40 AM]
looks mostly correct 👍

furf [11:41 AM]
just thinking out loud… might consider base64 encoding thumbs and images

furf [11:41 AM]
actionType could probably be type for an action object :simple_smile: (edited)

furf [11:42 AM]
not sure i love ref as a catch-all property but still just thnking out loud (edited)

furf [11:42 AM]
could use lat and lng for attend (edited)

furf [11:42 AM]
as well as a human-readable location

redbeard0x0a [12:06 PM]
@furf: I used actionType because type is a reserved word in some programming languages, so I never use 'type' as an attribute name.

redbeard0x0a [12:08 PM]
re-using ref is a lot more friendly to somebody manually editing the data compared to trying to remember which other field to use in which circumstance. It is something I would have typically have put in a JSON field or as an embedded object if we had a frontend to put the correct fields in the embedded object/json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants