Return null
when handling command result
#33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a command result is handled in HandleCommandResult, a
TerminalNode
is always returned, even if the command's result isnull
. This prevents execution from being passed through to other user-defined commands and the game's command parser. There's also a comment here indicating thatHandleCommandResult
should returnTerminalNode
ornull
, but currentlynull
is never returned.This PR simply adds a condition in
HandleCommandResult
to returnnull
when the command's result isnull
and fixes a typo in the comment mentioned previously.