Skip to content

Conversation

@jlnav
Copy link
Member

@jlnav jlnav commented Jan 7, 2026

I'm assuming that if-and-only-if generators return IDs that we'll want to map those to sim_ids. But what other conditions do we have to account for?

What behavior changes does libE still need, depending on if a gen returns IDs or not?

@jlnav jlnav requested a review from shuds13 January 7, 2026 20:36
@jlnav jlnav marked this pull request as ready for review January 7, 2026 20:36
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 58.37%. Comparing base (ea9c35c) to head (d12f53d).
⚠️ Report is 2 commits behind head on experimental/jlnav_plus_shuds_asktell.

Files with missing lines Patch % Lines
libensemble/generators.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                            Coverage Diff                            @@
##           experimental/jlnav_plus_shuds_asktell    #1646      +/-   ##
=========================================================================
- Coverage                                  58.37%   58.37%   -0.01%     
=========================================================================
  Files                                         80       80              
  Lines                                       8125     8127       +2     
  Branches                                    1234     1235       +1     
=========================================================================
+ Hits                                        4743     4744       +1     
  Misses                                      3099     3099              
- Partials                                     283      284       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlnav jlnav merged commit e3f2375 into experimental/jlnav_plus_shuds_asktell Jan 8, 2026
28 of 29 checks passed
@jlnav jlnav deleted the asktell/aposmm_id_attr branch January 8, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants