fix: pdf generation for on the reservation page#1036
Merged
JohnVillalovos merged 1 commit intodevelopfrom Feb 17, 2026
Merged
Conversation
Previously the JSON template lost its opening {, and after the recent
async change the PDF flow now waits on that malformed JSON, so .done()
never runs and the button appears dead.
Also add some default values if `null` values are present
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical PDF generation failure on the reservation page caused by a malformed JSON template. The template was missing its opening brace, which prevented the async PDF flow from completing, making the PDF generation button appear unresponsive.
Changes:
- Restored the missing opening brace in the JSON template
- Added default empty string values for null attributes to prevent JSON errors
- Added null check for date attribute values before formatting
Collaborator
Author
|
Eric on discord tested and said it fixed the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the JSON template lost its opening {, and after the recent async change the PDF flow now waits on that malformed JSON, so .done() never runs and the button appears dead.
Also add some default values if
nullvalues are present