Skip to content

test(phpstan): enable PHPStan level 3 for Pages/Ajax/#1039

Merged
JohnVillalovos merged 1 commit intodevelopfrom
jlvillal/phpstan_3
Feb 18, 2026
Merged

test(phpstan): enable PHPStan level 3 for Pages/Ajax/#1039
JohnVillalovos merged 1 commit intodevelopfrom
jlvillal/phpstan_3

Conversation

@JohnVillalovos
Copy link
Collaborator

Resolve PHPStan level 3 issues found when enabling checking of the Pages/Ajax/ directory.

Copilot AI review requested due to automatic review settings February 18, 2026 00:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables PHPStan “next” (level 3) analysis for Pages/Ajax/ by removing the exclusion and applying type-tightening fixes in Ajax pages so those files pass stricter static analysis.

Changes:

  • Removed Pages/Ajax/ from phpstan_next.neon excludePaths.
  • Normalized various Ajax request IDs to int to match documented contracts.
  • Tightened some PHPDoc types / return values used by reservation Ajax flows.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
phpstan_next.neon Removes the Pages/Ajax/ exclusion to include it in PHPStan level 3 checks.
lib/Application/Reservation/ReservationRetryParameter.php Updates PHPDoc return type for retry parameter parsing.
Pages/Ajax/UnavailableResourcesPage.php Casts schedule ID query param to int.
Pages/Ajax/ResourceDetailsPage.php Casts resource ID to int; updates repository PHPDoc to interface type.
Pages/Ajax/ReservationWaitlistPage.php Casts posted user/resource IDs to int.
Pages/Ajax/ReservationUserAvailabilityPage.php Casts schedule ID query param to int.
Pages/Ajax/ReservationUpdatePage.php Provides default update scope and returns it as a string.
Pages/Ajax/ReservationSavePage.php Casts posted IDs to int; normalizes additional resource IDs to int[]; adds local type assertion for retry params.
Pages/Ajax/ReservationMovePage.php Casts posted resource IDs to int.
Pages/Ajax/ReservationCreditsPage.php Casts posted IDs to int; normalizes additional resource IDs to int[].
Pages/Ajax/ReservationAttributesPrintPage.php Casts requested user ID query param to int.
Pages/Ajax/ReservationAttributesPage.php Casts requested user ID query param to int.

Resolve PHPStan level 3 issues found when enabling checking of the
`Pages/Ajax/` directory.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

@JohnVillalovos JohnVillalovos merged commit 58917c1 into develop Feb 18, 2026
21 checks passed
@JohnVillalovos JohnVillalovos deleted the jlvillal/phpstan_3 branch February 18, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant