test(phpstan): enable PHPStan level 3 for Pages/Ajax/#1039
Merged
JohnVillalovos merged 1 commit intodevelopfrom Feb 18, 2026
Merged
test(phpstan): enable PHPStan level 3 for Pages/Ajax/#1039JohnVillalovos merged 1 commit intodevelopfrom
Pages/Ajax/#1039JohnVillalovos merged 1 commit intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables PHPStan “next” (level 3) analysis for Pages/Ajax/ by removing the exclusion and applying type-tightening fixes in Ajax pages so those files pass stricter static analysis.
Changes:
- Removed
Pages/Ajax/fromphpstan_next.neonexcludePaths. - Normalized various Ajax request IDs to
intto match documented contracts. - Tightened some PHPDoc types / return values used by reservation Ajax flows.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| phpstan_next.neon | Removes the Pages/Ajax/ exclusion to include it in PHPStan level 3 checks. |
| lib/Application/Reservation/ReservationRetryParameter.php | Updates PHPDoc return type for retry parameter parsing. |
| Pages/Ajax/UnavailableResourcesPage.php | Casts schedule ID query param to int. |
| Pages/Ajax/ResourceDetailsPage.php | Casts resource ID to int; updates repository PHPDoc to interface type. |
| Pages/Ajax/ReservationWaitlistPage.php | Casts posted user/resource IDs to int. |
| Pages/Ajax/ReservationUserAvailabilityPage.php | Casts schedule ID query param to int. |
| Pages/Ajax/ReservationUpdatePage.php | Provides default update scope and returns it as a string. |
| Pages/Ajax/ReservationSavePage.php | Casts posted IDs to int; normalizes additional resource IDs to int[]; adds local type assertion for retry params. |
| Pages/Ajax/ReservationMovePage.php | Casts posted resource IDs to int. |
| Pages/Ajax/ReservationCreditsPage.php | Casts posted IDs to int; normalizes additional resource IDs to int[]. |
| Pages/Ajax/ReservationAttributesPrintPage.php | Casts requested user ID query param to int. |
| Pages/Ajax/ReservationAttributesPage.php | Casts requested user ID query param to int. |
Resolve PHPStan level 3 issues found when enabling checking of the `Pages/Ajax/` directory.
c1616b9 to
7f20f00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve PHPStan level 3 issues found when enabling checking of the
Pages/Ajax/directory.