Skip to content

Conversation

@plasticlobster
Copy link
Contributor

@plasticlobster plasticlobster commented Mar 20, 2025

What kind of change does this PR introduce? Bug fix

What is the current behavior? #1

What is the new behavior? No more missing map file.

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  1. I used terser to generate the missing babel.min.js.map file (based on node_modules/@babel/standalone/babel.js unminified javascript.
  2. I specified my codesandbox server in Librechat and generated an artifact
  3. I checked the console to ensure the missing .map file errors were cleared.

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

One thing worth mentioning is that this does not solve the issue raised in #2 - I don't believe that issue is a duplicate of the issue I'm addressing.

Nor does it solve this issue raised in LIbrechat that was converted to a discussion: danny-avila/LibreChat#3989

I can assure you that this is not related to a network problem, as running the server on both AWS infrastructure and on localhost has resulted in the same timeout errors being issued, and it seems to only apply to certain artifacts.

Also you may not agree with my README changes, the codesandbox-browserfs module does not get built unless you use the instructions in the CONTRIBUTING.md file (Specifically by running yarn start to force the codesandbox-browserfs build)

…ifies node 16, so 10 is likely outdated in the CONTRIBUTING.md file. The README.md file does not contain the steps from the CONTRIBUTING.md file for building the codesandbox-browserfs package. I suspect the yarn build:deps script needs to be updated to do this correctly, but the yarn start script does end up building this correctly. If you follow the instructions as written you get errors in both yarn build:deps and yarn build:sandpack, but if you use yarn start, you do not.
@danny-avila
Copy link
Contributor

Hi @plasticlobster thanks for investigating this. I will update the workflow to see if it still works.

One thing worth mentioning is that this does not solve the issue raised in #2 - I don't believe that issue is a duplicate of the issue I'm addressing.
Nor does it solve this issue raised in LIbrechat that was converted to a discussion: danny-avila/LibreChat#3989
I can assure you that this is not related to a network problem, as running the server on both AWS infrastructure and on localhost has resulted in the same timeout errors being issued, and it seems to only apply to certain artifacts.

The issue seems to be due to service workers not running based on the client connection, see: danny-avila/LibreChat#3989 (reply in thread)

It happens regardless of using the bundled files or not, so I'm not sure. Happy to be corrected on this, but it seems others were able to resolve this independent of the self-hosted sandpack files.

@danny-avila
Copy link
Contributor

Moving to new PR: #5

@danny-avila danny-avila closed this Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants