Disable Old Metric vitals Form #1629
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahanipeitra1994
changed the title
Contributor
|
LGTM |
muarachmann
requested changes
Jul 30, 2020
Contributor
Author
|
ok i will work on that |
Ngai-E
requested changes
Aug 16, 2020
|
|
||
| foreach ( $inDir as $fname ) | ||
| { | ||
| // added 8-2009 by BM - do not show the metric vitals form as option since deprecated |
Collaborator
There was a problem hiding this comment.
Remove the comments related to this code as well then it will be ready for merge.
Ngai-E
approved these changes
Aug 16, 2020
|
|
||
| foreach ( $inDir as $fname ) | ||
| { | ||
| // added 8-2009 by BM - do not show the metric vitals form as option since deprecated |
Collaborator
|
@maggienegm @muarachmann Is this okay now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed the "Disable Old Metric Vitals Form" issue #1626