Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[feature request] Add support for custom height of the currently higlighted pin#51

Open
joshuadeguzman wants to merge 4 commits intoLiewJunTung:masterfrom
joshuadeguzman:feat/add-support-for-enlarging-current-highlight-pin
Open

[feature request] Add support for custom height of the currently higlighted pin#51
joshuadeguzman wants to merge 4 commits intoLiewJunTung:masterfrom
joshuadeguzman:feat/add-support-for-enlarging-current-highlight-pin

Conversation

@joshuadeguzman
Copy link
Copy Markdown

@joshuadeguzman joshuadeguzman commented Aug 31, 2020

@LiewJunTung, let me know if this is something you would like to be merged on this plugin.

If this gets prioritized, this should be the next action items we can talk about:

TODO

  • Exposing the animation curve and duration for the added AnimatedContainer
  • Reverting changes made to the demo app back to the original ones (emoji masked inputs) or creating a new example screen
  • Clean up / format files

Changes

  • Add highlightPinBoxHeight, highlightPinBoxWidth, defaults to the default value of the pinBoxHeight and pinBoxWidth respectively
  • Wrap pin with AnimatedContainer to animate transition of the size, currently did not include unnecessary changes of the decoration
  • Format files

2020-08-31 15-39-32 2020-08-31 15_40_43

@LiewJunTung
Copy link
Copy Markdown
Owner

It does look cool! I'll play around with it first.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants