This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Fix issue the _onTextChanged function referencing out of bounds values#54
Open
tommysolsen wants to merge 1 commit intoLiewJunTung:masterfrom
Open
Fix issue the _onTextChanged function referencing out of bounds values#54tommysolsen wants to merge 1 commit intoLiewJunTung:masterfrom
tommysolsen wants to merge 1 commit intoLiewJunTung:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pincode library v1.7.1 seemingly throws an error like this
RangeError (length): Invalid value: Not in inclusive range 0..3: 4. Error thrown Instance of 'ErrorDescription'.whenever a user presses the backspace button.This might be related to another bug I am experiencing in the SDK where the back button removes two characters at once, but that happends in select Text boxes outside of this plugin so I expect it is not related to this plugin.
This PR removes the for loop and index counter and reimplements a function that is similar but does not use index variables in order to avoid these kinds of issues.