Skip to content

fix: resolve library manifest feature ID and alias collisions, schema violations#735

Open
yasinBursali wants to merge 1 commit intoLight-Heart-Labs:mainfrom
yasinBursali:fix/library-manifest-collisions-and-schema
Open

fix: resolve library manifest feature ID and alias collisions, schema violations#735
yasinBursali wants to merge 1 commit intoLight-Heart-Labs:mainfrom
yasinBursali:fix/library-manifest-collisions-and-schema

Conversation

@yasinBursali
Copy link
Copy Markdown
Contributor

What

  • Prefix colliding feature IDs with service names for uniqueness
  • Remove ambiguous CLI aliases shared across multiple extensions
  • Fix Milvus health port, Jan port binding security, and several schema violations

Why

  • Duplicate feature IDs cause last-writer-wins in dashboard feature registry
  • Shared aliases cause ambiguous dream <alias> CLI resolution
  • Milvus dashboard health check targeted gRPC port instead of HTTP admin port
  • Jan port bound to 0.0.0.0 instead of 127.0.0.1
  • Empty health strings, missing healthchecks, and endpoint mismatches violated schema

How

  • 7 feature IDs prefixed with <service>-<function> pattern
  • 6 alias deduplication: removed vector-db, flow, workflow duplicates
  • Milvus: port: 19530port: 9091 (HTTP admin for health), external_port unchanged
  • Jan: added 127.0.0.1: prefix, healthcheck uses 127.0.0.1
  • Dify: compose_file: compose.yaml.disabledcompose.yaml
  • Aider/Piper: removed empty health: ""
  • Baserow: added healthcheck stanza
  • Flowise: aligned health endpoint with compose healthcheck

Testing

  • All 66 YAML files validate ✅
  • Zero duplicate feature IDs or aliases ✅

Platform Impact

All platforms (YAML configuration only)

🤖 Generated with Claude Code

… violations

Prefix colliding feature IDs with service names to ensure uniqueness.
Remove ambiguous CLI aliases shared across multiple extensions. Fix
Milvus health port, Jan port binding, and several manifest schema
violations including empty health strings and missing healthchecks.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@Lightheartdevs Lightheartdevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Audit Review

Good cleanup — feature ID deduplication, alias collision removal, health endpoint fixes, and schema compliance corrections across 17 manifests. All necessary.

Blocking: Regenerate the catalog

"Check catalog is up-to-date" CI is failing. The manifest changes need a catalog regeneration before merge. Run the generator and commit the updated extensions-catalog.json.

Clarify: Milvus port change

The internal port changed from 19530 (gRPC client port) to 9091 (health/metrics port). If port is used for healthchecks, 9091 is correct. If used for client connections elsewhere, this could break things. The external_port_default stays at 19530 so external access is fine — just confirm what the codebase uses port for.

Good

  • Feature ID namespacing (e.g., image-generation -> forge-image-generation) prevents collisions
  • Alias deduplication across services
  • Removing empty health: "" fields
  • Flowise endpoint fix (/api/v1/health -> /api/v1/ping)
  • Jan port binding with 127.0.0.1 prefix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants