fix: replace localhost with 127.0.0.1 in all healthcheck definitions#736
Open
yasinBursali wants to merge 2 commits intoLight-Heart-Labs:mainfrom
Open
fix: replace localhost with 127.0.0.1 in all healthcheck definitions#736yasinBursali wants to merge 2 commits intoLight-Heart-Labs:mainfrom
yasinBursali wants to merge 2 commits intoLight-Heart-Labs:mainfrom
Conversation
…ibility Use explicit IPv4 address in llama-server healthcheck and extension compose template to prevent failures on dual-stack hosts where localhost resolves to ::1. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…tions Extend IPv4-explicit healthchecks to all compose files including core services, extensions, GPU overlays, and templates. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Lightheartdevs
requested changes
Apr 3, 2026
Collaborator
Lightheartdevs
left a comment
Lightheartdevs
left a comment
There was a problem hiding this comment.
Audit Review
The change itself is correct and follows Docker best practices — 127.0.0.1 is more reliable than localhost in containers that may lack /etc/hosts or resolve localhost to IPv6.
Blocking: Docker Compose validation CI failure
"Validate Docker Compose files" is failing. Investigate whether the changes introduced a syntax issue, or if this is the pre-existing llama-server image failure. If it's the pre-existing one (llama-server has no image in base.yml), then this is not blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace all
localhostreferences in Docker healthchecktest:lines with127.0.0.1to prevent IPv6 resolution failures.Why
On dual-stack hosts,
localhostmay resolve to::1(IPv6). Services listening only on IPv4 become unreachable, causing healthcheck failures that cascade throughdepends_on: condition: service_healthy— potentially bringing down the entire stack.How
19 replacements across 17 files:
docker-compose.base.yml,docker-compose.amd.yml, 12 extension compose files, and 2 extension templates. Only healthchecktest:lines changed — environment variables left untouched.Testing
localhostin active healthcheck lines ✅Platform Impact
All platforms (especially dual-stack Linux hosts with IPv6 enabled)
🤖 Generated with Claude Code