fix: resolve relative output path in preset export#739
Merged
Lightheartdevs merged 1 commit intoLight-Heart-Labs:mainfrom Apr 3, 2026
Merged
Conversation
The preset export command changes directory to $PRESETS_DIR before running tar. If the user provides a relative output path, the archive is created relative to PRESETS_DIR instead of the user's working directory. Now resolves relative paths to absolute before the cd. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
dream preset exportcreating archive in wrong directory when given relative path.Why
The command does
cd "$PRESETS_DIR"beforetar czf "$output", so relative output paths resolve against PRESETS_DIR instead of the user's working directory.How
Resolve relative paths to absolute before the
cd:Testing
bash -nsyntax check passesrealpath, justpwd+ string check)dream preset export mypreset ./backup.tar.gznow creates file in CWDReview
Critique Guardian: APPROVED
dream preset import— separate issue.Platform Impact
pwdis POSIX builtin, works identically🤖 Generated with Claude Code