fix: disable ComfyUI compose when image generation is off#741
Merged
Lightheartdevs merged 2 commits intoLight-Heart-Labs:mainfrom Apr 3, 2026
Merged
Conversation
When ENABLE_COMFYUI=false, the installer skips building the ComfyUI image but resolve-compose-stack.sh still includes its compose files. Docker compose up then fails with "No such image" for ComfyUI, which blocks ALL containers from starting. Now renames compose.yaml to compose.yaml.disabled in Phase 03 when ComfyUI is not enabled, leveraging the existing disabled-extension convention that the resolver already respects. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When re-installing with ENABLE_COMFYUI=true from a source tree where a previous install disabled ComfyUI, the compose.yaml.disabled is now renamed back to compose.yaml. This closes a re-install edge case where ComfyUI would silently remain disabled. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Exclude ComfyUI compose files from the Docker Compose stack when image generation is disabled.
Why
When
ENABLE_COMFYUI=false(non-interactive without--all, or Tier 0/1 safety net), the installer skips building the ComfyUI image butresolve-compose-stack.shstill includes its compose files.docker compose upthen fails with "No such image: dream-server-comfyui:latest", blocking ALL containers from starting — not just ComfyUI.How
Added a block at the end of Phase 03 that syncs ComfyUI compose state with the
ENABLE_COMFYUIflag:compose.yaml→compose.yaml.disabled(resolver already skips.disabled)Uses the existing
.disabledconvention thatresolve-compose-stack.shanddream-cli enable/disablealready respect.Testing
bash -nsyntax check passes.disabledat line 169dream enable comfyuiuses same rename conventionReview
Critique Guardian: APPROVED (after adding companion re-enable block for re-install edge case)
Platform Impact
gpu_backends: [amd, nvidia], no Apple support.🤖 Generated with Claude Code