fix: 6 installer/runtime bugs (P0 privacy-shield crash, P0 phase-13 false failure, P1-P3)#749
Merged
Lightheartdevs merged 7 commits intomainfrom Apr 3, 2026
Merged
Conversation
…uth check Fixes #743. The Security() dependency with auto_error=False has version- dependent behavior across FastAPI releases, causing a TypeError crash-loop on /health and /stats endpoints. Replace with direct request.headers parsing — works on all FastAPI versions, keeps secrets.compare_digest for timing safety. Docker healthcheck gets 200 without auth. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fixes #744. Phase 13 is informational (URLs, shortcuts, preflight validation). Under set -euo pipefail, any stray non-zero exit code (e.g., a crashing privacy-shield health probe, missing systemctl) triggers the cleanup_on_error trap and prints "[ERROR] Installation failed during phase: 13-summary" even though everything is running. Wrap Phase 13 in set +e so summary-phase failures become warnings, not installation aborts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fixes #745. NVIDIA ComfyUI compiles from source (~25-40 min) while AMD pulls a pre-built image (instant). The installer showed "~5-10 minutes" for all backends. Now shows the longer estimate for NVIDIA+ComfyUI and prints a clear warning before the build starts in Phase 11. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fixes #746. Embeddings (TEI) was missing from Phase 12's health check list. On first run, the model load takes 1-2 minutes, causing a brief [BAD] status that self-resolves. Adding it to Phase 12 with 30 attempts ensures the installer waits for embeddings before proceeding to summary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ng hint Fixes #747. The old message "will retry on next start" was vague. Now says "will attempt again during service startup" with a hint to check network and disk space. The retry logic itself works correctly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fixes #748. The NVIDIA Docker runtime warning fired on AMD Strix Halo systems because the default backend fallback was "nvidia" when no GPU was detected via sysfs. Changed default to "cpu", added explicit elif/else branches so NVIDIA warnings only show for NVIDIA backends, and added /dev/dri positive check for AMD. CPU mode gets a clean pass. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sensitive Files DetectedTrigger: Security-sensitive files detected: dream-server/installers/ Files flagged: Extra human review is recommended for this PR. Claude Code Review | Sensitive File Detection | ~$1.50 |
Fixes Ruff F401 lint error introduced by the manual auth refactor. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sensitive Files DetectedTrigger: Security-sensitive files detected: dream-server/installers/ Files flagged: Extra human review is recommended for this PR. Claude Code Review | Sensitive File Detection | ~$1.50 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 6 bugs found during install testing on .143, .199, and .213 builds.
P0 — Every install hits these
Security(auto_error=False)has version-dependent behavior across FastAPI releases, causing TypeError on/healthand/stats. Replaced with directrequest.headersparsing — works on all versions, keepssecrets.compare_digestfor timing safety.set -euo pipefail, any stray non-zero exit in the summary phase triggers[ERROR] Installation failedeven though everything is running. Wrapped Phase 13 inset +e— summary is informational, not a gate.P1 — Bad UX
P2-P3 — Cosmetic/timing
Files changed
dream-server/extensions/services/privacy-shield/proxy.py— manual auth checkdream-server/install-core.sh— set +e around Phase 13dream-server/installers/phases/08-images.sh— conditional time estimatedream-server/installers/phases/11-services.sh— ComfyUI build warningdream-server/installers/phases/12-health.sh— embeddings health checkdream-server/dream-preflight.sh— backend-gated GPU warningTest plan
curl http://localhost:8085/healthreturns 200 without authbash -npasses on all modified shell scriptspython -m py_compilepasses on proxy.pyCloses #743, closes #744, closes #745, closes #746, closes #747, closes #748