Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Nov 18, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did all existing and newly added tests pass locally?

What does this PR do?

moving on from dead snake...

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.


📚 Documentation preview 📚: https://lit-utilities--331.org.readthedocs.build/en/331/

@github-actions github-actions bot added ci/cd Continuous integration and delivery package tests labels Nov 18, 2024
@codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@a6a350f). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             main   #331   +/-   ##
=====================================
  Coverage        ?    62%           
=====================================
  Files           ?     17           
  Lines           ?    692           
  Branches        ?      0           
=====================================
  Hits            ?    426           
  Misses          ?    266           
  Partials        ?      0           
---- 🚨 Try these New Features:

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 18, 2024
@Borda
Copy link
Collaborator Author

Borda commented Nov 18, 2024

trying to fix it with google/python-fire#571

@Borda Borda changed the title bump: min Python 3.9 bump: min Python 3.9 [blocked] Nov 26, 2024
@Borda Borda changed the title bump: min Python 3.9 [blocked] bump: min Python 3.9 Dec 16, 2024
@Borda Borda merged commit 84f9251 into main Dec 16, 2024
58 checks passed
@Borda Borda deleted the bump/py3.9 branch December 16, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd Continuous integration and delivery dependencies documentation Improvements or additions to documentation package tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant