fix: prefix node keys to resolve naming conflict#6
Conversation
NODE_CLASS_MAPPINGS keys PromptGenerator and StyleApplier conflicted with 3 other packages. Prefixed with Limbicnation_ to match PublisherId. Bumped version to 1.2.0.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses potential naming conflicts within the ComfyUI ecosystem by introducing a unique prefix to the node keys, ensuring better compatibility and preventing issues when integrating with other custom nodes. Additionally, the project version has been updated to reflect these significant changes, providing a clear indication of the update. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request prefixes the node class mappings with Limbicnation_ to prevent naming conflicts with other custom nodes, which is a good practice. The version number is also correctly updated across pyproject.toml and CLAUDE.md. The changes look good, but I've identified a couple of documentation inconsistencies that should be addressed to keep the project documentation in sync with the code changes.
| ComfyUI custom node that generates Stable Diffusion prompts using Ollama. Users provide a brief description and select a style preset; the node outputs a detailed, optimized prompt. Supports LoRA-enhanced models with automatic discovery and prioritization. | ||
|
|
||
| **Current version**: `1.1.7` | ||
| **Current version**: `1.2.0` |
There was a problem hiding this comment.
While updating the version, I noticed the architecture overview in this file (lines 13-20) is incomplete. It's missing nodes/style_applier_node.py, which is registered in __init__.py and provides the StyleApplierNode. It would be beneficial to add it to the file tree for a complete architectural overview.
| "Limbicnation_PromptGenerator": "Prompt Generator (Qwen)", | ||
| "Limbicnation_StyleApplier": "Style Applier", |
There was a problem hiding this comment.
The display names for both nodes have been changed, removing the leading emojis. The project's documentation should be updated to reflect this for consistency. For example, line 51 of README.md still refers to the PromptGeneratorNode as **🎨 Prompt Generator (Qwen)**.
1 participant
Summary
NODE_CLASS_MAPPINGSkeys withLimbicnation_to resolve conflict with 3 other packages (comfyui-adaptiveprompts, ComfyUI-Prompt-Manager, ComfyUI-RndNanthu)Test plan
text/generation