Skip to content

fix: detect iOS in TextureFormatSelector#86

Merged
Limitex merged 3 commits intoLimitex:mainfrom
kurotu:fix/ios-uncompressed
Feb 12, 2026
Merged

fix: detect iOS in TextureFormatSelector#86
Limitex merged 3 commits intoLimitex:mainfrom
kurotu:fix/ios-uncompressed

Conversation

@kurotu
Copy link
Contributor

@kurotu kurotu commented Feb 11, 2026

🔍 What type of PR is this?

  • 🐛 Bug fix
  • ✨ New feature
  • 📖 Documentation update
  • 🎨 Refactoring
  • 🧪 Test
  • ⏪ Revert
  • 📝 Other

📝 Description

Fixed the issue where uncompressed textures were compressed with PC format on iOS build target

🔗 Related Issue

No related issues.

✅ Changes

  • Added iOS detection to TextureFormatSelector.ResolvePlatform().
  • Added iOS to texture compressor documentation.

⚠️ Breaking Changes

  • Yes, this PR contains breaking changes.
  • No, this PR is fully backward-compatible.

🧪 Testing

Please describe the tests that you ran to verify your changes.

  • Confirmed it works in Unity 2022.3.22f1
  • Confirmed package import via VRChat Creator Companion
  • Verified texture compression works correctly on test avatars
  • RGBA32 textures are compressed with ASTC on iOS build target

📸 Screenshots / Videos

N/A

💌 To the Reviewers

N/A

Additional Context

N/A

Copilot AI review requested due to automatic review settings February 11, 2026 12:36
@kurotu kurotu force-pushed the fix/ios-uncompressed branch from 5758bdc to 32588a8 Compare February 11, 2026 12:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where iOS builds were incorrectly using Desktop (DXT/BC) texture compression formats instead of Mobile (ASTC) formats. The fix adds iOS to the platform detection logic in TextureFormatSelector.ResolvePlatform(), ensuring that iOS builds use the appropriate ASTC compression formats like Android builds already do.

Changes:

  • Modified platform detection to classify iOS as a Mobile platform alongside Android
  • Updated documentation to reflect iOS support in texture format descriptions

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
Editor/TextureCompressor/Core/Services/TextureFormatSelector.cs Added iOS to the BuildTarget check in ResolvePlatform() method to classify it as Mobile platform
Documentation~/avatar-compressor-docs/content/docs/components/texture-compressor.mdx Updated English documentation to include iOS in Mobile platform references
Documentation~/avatar-compressor-docs/content/docs.ja/components/texture-compressor.mdx Updated Japanese documentation to include iOS in Mobile platform references
CHANGELOG.md Added entry in Unreleased section documenting the bug fix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Owner

@Limitex Limitex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! I've reviewed the changes and everything looks good. Merging now.

Note: The release may be slightly delayed as I'm currently reworking the VPM package distribution system.

@Limitex Limitex merged commit a99e550 into Limitex:main Feb 12, 2026
5 checks passed
@kurotu kurotu deleted the fix/ios-uncompressed branch February 12, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants