Opinionated pull request, feel free to reject it, but please consider and see if it would be interesting for you#29
Open
asasvirtuais wants to merge 3 commits intoLinusU:masterfrom
asasvirtuais:master
Open
Opinionated pull request, feel free to reject it, but please consider and see if it would be interesting for you#29asasvirtuais wants to merge 3 commits intoLinusU:masterfrom asasvirtuais:master
asasvirtuais wants to merge 3 commits intoLinusU:masterfrom
asasvirtuais:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I am currently studying authentication methods and I decided to try out SRP, this repo seemed to a good start for me, so I forked it and started to do my stuff.
I moved everything to typescript to the best of my abilities, I moved the source code to src and the transpiled code is generated on /es5 and /es6, I also replaced a padStart dependency with JS padStart
Unfortunely in the end I couldn't get it to work for me, I left a comment describing the error I found on the line where it first shows up
I also abandoned the project to try out the OPAQUE protocol, but anyways. Hope you find some use for this.