feat(ai-plugin): implement AI model auto-detection and enhance plugin loading reliability #837
+190
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am thinking about whether model-detectors should be incorporated into the ai plugin... |
LinuxSuRen
reviewed
Sep 29, 2025
Adds support for AI-powered features via a new extension mechanism. This includes dynamically loading the AI extension's CSS and JS, and retrying the plugin mounting process with exponential backoff to ensure proper initialization. Also, provides a basic GRPC querying functionality which could call AI methods, and converts the AI response to standard data format. The AI plugin can be built from source or downloaded from a binary URL.
Restore two essential bug fixes that were incorrectly removed: 1. vite.config.ts fixes: - Fix test-id removal logic: only remove in production, preserve for E2E tests - Improve build performance: replace single chunk with optimized chunk splitting - Separate vue, element-plus, and vendor chunks for better caching 2. App.vue fix: - Fix Extension component prop: use menu.index instead of menu.name - Ensures AI plugin can be correctly identified and loaded These fixes are critical for AI plugin functionality and should not be reverted.
Consolidates the vite build configuration to output a single chunk, simplifying the config and potentially improving build times in some scenarios. The previous manual chunk configuration is removed.
Updates the AI model name description to indicate that the model is automatically detected from available models. Sets the default value for the model to an empty string, reflecting the auto-detection behavior.
…AI parameters. Adjust the stores.yaml file structure and add more configuration parameters such as provider and endpoint for AI plug-ins.
The AI plugin build process is removed from the makefile. The AI plugin is assumed to be pre-built or handled by a separate process, simplifying the build and execution flow.
yuluo-yx
reviewed
Sep 29, 2025
yuluo-yx
reviewed
Sep 29, 2025
yuluo-yx
reviewed
Sep 29, 2025
LinuxSuRen
reviewed
Sep 30, 2025
Comment on lines
+490
to
+494
| params := map[string]string{ | ||
| "model": query["model"], | ||
| "prompt": query["prompt"], | ||
| "config": query["config"], | ||
| } |
There was a problem hiding this comment.
Do you think it's necessary? It looks like you just convert the map data into a JSON string.
There was a problem hiding this comment.
Good catch! Added comments in 6171a02 to clarify the intent.
The function intentionally filters out the "method" field (used for routing)
before encoding - it's not just a simple map-to-JSON conversion.
(Or we can use Go structs instead of maps to provide better type safety?)
- Remove console.log/error from Extension.vue for production readiness - Add comments to encodeAIGenerateParams explaining field filtering logic Resolves review feedback from yuluo-yx and LinuxSuRen
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
implement AI model auto-detection and enhance plugin loading reliability
What this PR does / why we need it:
This PR introduces comprehensive AI plugin integration capabilities with intelligent model detection and robust plugin loading mechanisms. The changes address critical reliability issues in plugin initialization and provide a foundation for dynamic AI model management.
Key Features:
AI Model Auto-Detection System (
pkg/testing/model_detector.go)Enhanced Plugin Loading Reliability (
console/atest-ui/src/views/Extension.vue)AI Plugin Communication Infrastructure (
pkg/testing/remote/grpc_store.go)ai.generate,ai.capabilities)Configuration Optimization (
cmd/testdata/stores.yaml)unix:///tmp/atest-ext-ai.sock)Development Environment Improvements
Why we need it:
Testing:
This PR transforms the AI plugin system from a basic proof-of-concept into a production-ready, intelligent, and reliable integration platform.