Skip to content

Drush does not use .php extension after 9.x#125

Merged
WengerK merged 1 commit intoLionsAd:masterfrom
Fastglass-LLC:fix-path-to-drush
Jun 24, 2019
Merged

Drush does not use .php extension after 9.x#125
WengerK merged 1 commit intoLionsAd:masterfrom
Fastglass-LLC:fix-path-to-drush

Conversation

@taz77
Copy link
Contributor

@taz77 taz77 commented Jun 11, 2019

After Drush 9.x the ./composer/vendor/bin/drush.php was dropped. 8.x versions of Drush had both the drush.php and the drush versions. Since Drupal_TI requires at least 8.0.* there should be no backward compatibility problem.

@coveralls
Copy link

coveralls commented Jun 11, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 95e39a1 on Fastglass-LLC:fix-path-to-drush into 5316cdd on LionsAd:master.

@taz77 taz77 force-pushed the fix-path-to-drush branch from fb2a182 to 95e39a1 Compare June 15, 2019 14:25
@taz77
Copy link
Contributor Author

taz77 commented Jun 15, 2019

Updated PR with changes in Master.

@WengerK
Copy link
Collaborator

WengerK commented Jun 18, 2019

Thanks for this PR, I applied it on my own PR some days ago (as I get the same issue as you #126).

I would like to finish #126 before merging any more changes. For now we can't trust our tests CI as a lot of them are deprecated code or no up-to-date - wanna help me on #126 ?

@taz77
Copy link
Contributor Author

taz77 commented Jun 22, 2019

How about we get this merged? The issue addressed here is preventing Drupal_TI from running at all. Being a module maintainer, I need my tests to run and I cannot move forward because it cannot find Drush.

@WengerK WengerK merged commit e6c53cf into LionsAd:master Jun 24, 2019
@taz77
Copy link
Contributor Author

taz77 commented Jul 11, 2019

@WengerK do you have rights to the Packagist account?

@WengerK
Copy link
Collaborator

WengerK commented Jul 12, 2019

Nope, what for ?

@taz77
Copy link
Contributor Author

taz77 commented Jul 12, 2019

Packagist needs to be updated. It does not have the latest dev-master code.

@WengerK
Copy link
Collaborator

WengerK commented Jul 16, 2019

You can force the commit in your own travis.yml - if needed.

@LionsAd
Copy link
Owner

LionsAd commented Jul 16, 2019

What do I need to do to refresh packagist?

@taz77
Copy link
Contributor Author

taz77 commented Jul 16, 2019

@LionsAd When you sign into Packagist and go to your projects there is an "Update" button. This will cause Packagist to get the latest dev.

@WengerK Yes, you can specify a hash but that causes Composer to run git to pull from Github which if you don't have Github credentials setup then you typically will never be able to pull because Travis maxes out the API limits on Github at any given time for anonymous calls.

@LionsAd
Copy link
Owner

LionsAd commented Jul 16, 2019

Done, thanks for bringing that to my attention.

@taz77 taz77 deleted the fix-path-to-drush branch July 16, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants