refactor(test): split escrow tests into focused modules#133
Merged
mikewheeleer merged 3 commits intoLiquifact:mainfrom Apr 1, 2026
Merged
refactor(test): split escrow tests into focused modules#133mikewheeleer merged 3 commits intoLiquifact:mainfrom
mikewheeleer merged 3 commits intoLiquifact:mainfrom
Conversation
|
@oderahub Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
8b91686 to
93e136e
Compare
Contributor
Author
|
@mikewheeleer attention |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the escrow test suite into focused feature-based modules to
improve maintainability, reviewability, and long-term scalability without
changing contract behavior.
Closes #23
What changed
escrow/src/test/
setup consistent
the new module structure
Test organization
Tests are now grouped by feature area:
baselines
selection
boundaries, and dust sweep
collateral metadata
Shared helpers remain in escrow/src/test.rs. Each test creates a fresh Env
and local setup so modules do not depend on hidden cross-test state.
Validation
Ran locally:
cargo fmt --all -- --check
cargo test
Result:
Security notes
environment setup
the split
Why this helps
This makes the escrow suite easier to audit, extend, and review as coverage
grows, especially around security-sensitive flows like funding, settlement,
claims, admin controls, and boundary conditions.