fix: issue with aoe subteams with team participants#7448
fix: issue with aoe subteams with team participants#7448
Conversation
Rathoz
force-pushed
the
fix-aoe-subteam-issues
branch
from
63af91c to
2e3520a
Compare
There was a problem hiding this comment.
Pull request overview
Fixes missing team roster/flag variable storage for subteam (A/B variant) participants by ensuring the team’s template identifier is included among the stored aliases, improving downstream retrieval in match parsing/display.
Changes:
- Add
opponent.templateto the alias list generated for each parsed team participant. - This results in additional alias-based variable storage paths for teams, helping match modules find roster/flag data for subteams.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| local aliases = Array.parseCommaSeparatedString(input.aliases, ';') | ||
| table.insert(aliases, Opponent.toName(opponent)) | ||
| table.insert(aliases, opponent.template) |
There was a problem hiding this comment.
This should not be necessary with the changes to TT.getPageName, as `Opponent.toName uses that, right?
| table.insert(aliases, opponent.template) |
There was a problem hiding this comment.
GetPageName works the same as before, other than it reuses a new function
There was a problem hiding this comment.
Template names are lower case as well, while a pagename is not necessarily
There was a problem hiding this comment.
GetPageName works the same as before, other than it reuses a new function
The diff made it easy to misread, sorry.
However, if toName still uses redirects resolved page names, this would still run into issue when e.g. enriching placement data in TeamParticipants
Summary
Resolves #7217
How did you test this change?
dev