[Draft] TeamCard legacy wrapper spec — for alignment before implementation by Eetwalt · Pull Request #7475 · Liquipedia/Lua-Modules

Eetwalt · 2026-05-07T11:05:16Z

Summary

⚠️ This is a design spec for alignment, not an implementation PR.
No code changes — only the design document at docs/superpowers/specs/2026-05-06-teamcard-legacy-wrapper-design.md.
Please review and comment so we agree on the approach before any code is written.
The PR will be closed (not merged) after review; the spec file itself is local-only and will be removed before implementation lands.

How did you test this change?

n/a — spec only, no code changes.

Rathoz · 2026-05-07T11:39:40Z

+1. `Custom.run` calls `LegacyTeamCard.run(Custom.config)` (where `Custom.config` is a table of per-wiki overrides — see Section 7).
+2. `Legacy.run` retrieves all stashed args via `Template.retrieveReturnValues('LegacyTeamCard')`.
+3. First entry = header (from `columns start`); remaining entries = cards (from each `TeamCard`).
+4. Header is mapped into TP top-level args (`minimumplayers`, `store`, `date`); per-card `import=false` is set on each opponent.


Top level date should not be needed (doesn't exist), only opponent level date?

Rathoz · 2026-05-07T11:40:46Z

+Wiki templates (on-wiki, edited at deploy):
+  Template:TeamCard columns start  → invoke Module:Template fn=stashArgs namespace=LegacyTeamCard
+  Template:TeamCard                → invoke Module:Template fn=stashArgs namespace=LegacyTeamCard
+  Template:TeamCard columns end    → invoke Module:TeamCard/Legacy/Custom fn=run


Technically one more tempalte that we need to care about at deploy. The toogle pplayers button

Rathoz · 2026-05-07T11:43:04Z

+6. The wrapper sets the `team` / `teamRR` global page vars from the first non-TBD card (preserving an old TC behavior that TP's `setPageVars` doesn't cover).
+7. The collected TP args are passed into a render path equivalent to `TeamParticipantsController.fromTemplate`, which itself calls `TeamParticipantsRepository.save` (storing in a TC-compatible shape) and `TeamParticipantsRepository.setPageVars` (defining the per-team / per-player wiki vars).
+
+## Section 1 — Module layout & wiki templates


Do we need to care about TeamPartipantGroups (mapping the old Team Card manual groupings into the new one)?

Rathoz · 2026-05-07T11:44:50Z

+| `Template:TeamCard columns start` | `<div class="template-box">…<#vardefine>` | `{{#invoke:Lua\|invoke\|module=Template\|fn=stashArgs\|namespace=LegacyTeamCard}}` |
+| `Template:TeamCard` | `{{#invoke:Lua\|invoke\|module=TeamCard\|fn=draw\|...}}` | `{{#invoke:Lua\|invoke\|module=Template\|fn=stashArgs\|namespace=LegacyTeamCard}}` |


Just FYI, may need to insert an empty div or something similiar inorder for MW parser to be happy, otherwise it may insert
for each call

yes you need to insert empty div for mw not to add a ton of linebreaks

Rathoz · 2026-05-07T11:45:38Z

+| TC header param | TP top-level arg | Notes |
+|---|---|---|
+| `defaultRowNumber` | `minimumplayers` | Closest semantic match. |
+| `disable_storage`/`nostorage` (header-level) | `store = false` (top-level) | Honored only when set on the header, since TP's `store` is top-level. Per-card occurrences are ignored (out-of-scope). |


Never set on the heading in TC afaik

Rathoz · 2026-05-07T11:46:46Z

+
+Hardcoded by the wrapper:
+- `import = false` is set **per card** (not at header level — TP reads `import` off each Opponent), so old pages use explicit rosters.
+- `store` defaults to true (TP's default) unless the header disabled storage. TP's `Repository.save` produces records with the same `objectName` shape as old TC and the same legacy participant fields via `Opponent.toLegacyParticipantData`.


store doesn't need to be hardcoded tby the wrapper. The existing logic will take care o whther r not it's needed. Hardcoding would force it to store even if SaveLpdb=false from wiki vars.

Rathoz · 2026-05-07T11:47:15Z

+Hardcoded by the wrapper:
+- `import = false` is set **per card** (not at header level — TP reads `import` off each Opponent), so old pages use explicit rosters.
+- `store` defaults to true (TP's default) unless the header disabled storage. TP's `Repository.save` produces records with the same `objectName` shape as old TC and the same legacy participant fields via `Opponent.toLegacyParticipantData`.
+- `date` — passed through if set on header, else TP's tournament-date default applies.


Don't think that date needs to be set by the wrapper (doesn't exist on this level afik in TC). TP handles fallbacks

Rathoz · 2026-05-07T11:48:07Z

+- `store` defaults to true (TP's default) unless the header disabled storage. TP's `Repository.save` produces records with the same `objectName` shape as old TC and the same legacy participant fields via `Opponent.toLegacyParticipantData`.
+- `date` — passed through if set on header, else TP's tournament-date default applies.
+
+Before invoking the TP render, the wrapper also sets two global page vars from the first non-TBD card (matching old TC behavior): `team` (resolved team name at `tournament_date`) and `teamRR` (redirect-resolved name). TP's `setPageVars` does the per-team `<TeamName>_pN` style vars itself, so those are not duplicated here.


What? Is this needed? Not sure

Rathoz · 2026-05-07T11:49:20Z

+
+Before invoking the TP render, the wrapper also sets two global page vars from the first non-TBD card (matching old TC behavior): `team` (resolved team name at `tournament_date`) and `teamRR` (redirect-resolved name). TP's `setPageVars` does the per-team `<TeamName>_pN` style vars itself, so those are not duplicated here.
+
+If the first stash entry contains a `team` key (i.e. it looks like a card, not a header — defensive case for pages where `columns start` is missing or malformed), treat all entries as cards and synthesize an empty header.


Spit out a warning or tracking category if this happens. The "columns end" template might be missing then too

Rathoz · 2026-05-07T11:50:39Z

+|---|---|---|
+| `link` (or fallback to `team`) | positional `[1]` (template) | TC's `team` is the display name, `link` is the team template. The wrapper uses `args.link or args.team` for the TP template arg. |
+| `team` (display name) | dropped | TP derives display from the team template; no separate display override. |
+| `team2`/`team3` set | TP `contenders` (list of team templates) | Maps to TP's `contenders` parsing path: opponent becomes TBD with `potentialQualifiers` populated from each team template (`Opponent.readOpponentArgs({type=team, template=…})`). `link2`/`link3` are used as templates if present. |


Don't forget about team when using team2, team3 for contenders

Rathoz · 2026-05-07T11:51:35Z

+| `image1`/`imagedark1`/`imagesize` | dropped | TP gets logos from team templates. Image override (#7295) was reverted (#7449). |
+| `flag` (header flag) | dropped | No TP equivalent. |


Rathoz · 2026-05-07T11:52:09Z

+| `notes` | appended to `notes` list as `{text=notes, highlighted=false}` | |
+| `inotes` | appended to `notes` list as `{text=inotes, highlighted=false}` | If both `notes` and `inotes` are set, both entries are added to the TP `notes` list. |


The text parameter is wrong I think? The text should be the onctent of the note or inote, not a hardcoded string.

Suggested change

| `notes` | appended to `notes` list as `{text=notes, highlighted=false}` | |

| `inotes` | appended to `notes` list as `{text=inotes, highlighted=false}` | If both `notes` and `inotes` are set, both entries are added to the TP `notes` list. |

| `notes` | appended to `notes` list as `{[1] = value, highlighted=false}` | |

| `inotes` | appended to `notes` list as `{[1] = value, highlighted=false}` | If both `notes` and `inotes` are set, both entries are added to the TP `notes` list. |

It's this right?

Rathoz · 2026-05-07T11:56:59Z

+| `pNdnp` (truthy) | `played = false` | `dnp` wins over `played`/`result` if both set. |
+| `pNplayed` / `pNresult` | `played` (boolean) | |


Verify functionality when in combination with certain config parameters. They can interact weirdly, especially with, e.g., subs.

Rathoz · 2026-05-07T12:00:07Z

+| `c1` (default) | `role = head coach` | First coach is head coach. Override via per-wiki `coachRoles` config (Section 7). |
+| `c2..cN` (default) | `role = coach` | Override via per-wiki `coachRoles` config. |


Don't assume this. Any coach without a role should be assumed to be the role "Coach".

Rathoz · 2026-05-07T12:00:48Z

+
+**Coach mapping** (per `cN`, `scN`, `fcN`, `t2cN`, `t3cN`):
+
+| TC param | TP `Person` field | Notes |


I think cNpos needs to be mapped as well

Rathoz · 2026-05-07T12:05:08Z

+
+| Key | Type | Default | Purpose |
+|---|---|---|---|
+| `coachRoles` | `string[]` | `{'head coach', 'coach'}` | Role assigned to `cN` by index — `coachRoles[1]` → `c1`, `coachRoles[2]` → `c2`, with `'coach'` for any further coaches beyond the array length. |


Don't think this is needed. Map by cNpos. Default to coach

Rathoz · 2026-05-07T12:05:23Z

+| Key | Type | Default | Purpose |
+|---|---|---|---|
+| `coachRoles` | `string[]` | `{'head coach', 'coach'}` | Role assigned to `cN` by index — `coachRoles[1]` → `c1`, `coachRoles[2]` → `c2`, with `'coach'` for any further coaches beyond the array length. |
+| `positionMapping` | `table<string, string>` | `{}` (identity / TP-RoleUtil-only) | Maps TC `pNpos` values to TP `role` values when the wiki uses non-standard position labels (e.g. dota2 might map `1` → `'carry'`). When empty, `pNpos` is passed through as-is and `RoleUtil.readRoleArgs` normalizes it. |


Should be normalized later anyway. Probably not needed

Rathoz · 2026-05-07T12:06:35Z

+| `playerParamMap` | `table<string, string>` | `{}` | Optional per-wiki rename of TC player suffixes to TP person fields (e.g. `{ ['pNheroes'] = 'extradata.heroes' }`) for wiki-specific input. Empty default; rarely needed. |
+| `coachParamMap` | `table<string, string>` | `{}` | Same shape as `playerParamMap`, applied to `cN`/`scN`/`fcN` etc. |
+| `cardParamMap` | `table<string, string>` | `{}` | Per-wiki rename of TC card-level params to TP opponent fields. |


Not sure if theres are needed outside of dota. I think only dota need a forced number mapping

Rathoz · 2026-05-07T12:06:49Z

+| `playerParamMap` | `table<string, string>` | `{}` | Optional per-wiki rename of TC player suffixes to TP person fields (e.g. `{ ['pNheroes'] = 'extradata.heroes' }`) for wiki-specific input. Empty default; rarely needed. |
+| `coachParamMap` | `table<string, string>` | `{}` | Same shape as `playerParamMap`, applied to `cN`/`scN`/`fcN` etc. |
+| `cardParamMap` | `table<string, string>` | `{}` | Per-wiki rename of TC card-level params to TP opponent fields. |
+


Missing config for the very important for biz logic property

subdnpdefault

hjpalpha

this wrapper is not applicable for sc, sc2, sg

hjpalpha · 2026-05-07T13:50:28Z

+
+## Out of scope
+
+- Per-wiki bot-edit work to insert `{{TeamCard columns start}}` / `{{TeamCard columns end}}` around naked `{{TeamCard}}` runs. The wrapper assumes columns markers are always present.


maybe a bot run with
"\{\{[bB]ox\s*\|\s*start[^\}]*\}\}\s*\{\{[tT]eamCard" "{{TeamCard columns start}}\n{{TeamCard"
"\{\{[bB]ox\s*\|\s*break[^\}]*\}\}\s*\{\{[tT]eamCard" "{{TeamCard"
"\{\{[tT]eamCard([^\}]*)\}\}\s*\{\{[bB]ox\s*\|\s*end\}\}" "{{TeamCard\1}}\n{{TeamCard columns end}}"
prior?

note for myself - prep bot run on sc (<2k), sc2 (~300), sg (<100):

pwb replace -lang:starcraft2 -transcludes:TeamCard -regex -summary:"prep for conversion" "\{\{[bB]ox\s*\|\s*start[^\}]*\}\}\s*\{\{[tT]eamCard" "{{TeamList\n|{{TeamCard" "\{\{[bB]ox\s*\|\s*break[^\}]*\}\}\s*\{\{[tT]eamCard" "|{{TeamCard" "\{\{[tT]eamCard([^\}]*)\}\}\s*\{\{[bB]ox\s*\|\s*end\}\}" "|{{TeamCard\1}}\n}}"

allows the wrapper in place apply to be a simple template adjust + purge run
(for subst inner ones need to be converted to use json (with subst) plus the outer one using the conversion wrapper which generates the wiki code)

specs v2

de8238d

Eetwalt added documentation Improvements or additions to documentation c: team_card g: arenafps ArenaFPS c: team_participant labels May 7, 2026

Rathoz reviewed May 7, 2026

View reviewed changes

ElectricalBoy removed g: arenafps ArenaFPS labels May 7, 2026

hjpalpha reviewed May 7, 2026

View reviewed changes

revised spec

1e6624e

hjpalpha reviewed May 8, 2026

View reviewed changes

Comment thread docs/superpowers/specs/2026-05-06-teamcard-legacy-wrapper-design.md Outdated

Comment thread docs/superpowers/specs/2026-05-06-teamcard-legacy-wrapper-design.md Outdated

small tweaks

47e101b

chore: update visual snapshots

d12a637

		\| `Template:TeamCard columns start` \| `<div class="template-box">…<#vardefine>` \| `{{#invoke:Lua\\|invoke\\|module=Template\\|fn=stashArgs\\|namespace=LegacyTeamCard}}` \|
		\| `Template:TeamCard` \| `{{#invoke:Lua\\|invoke\\|module=TeamCard\\|fn=draw\\|...}}` \| `{{#invoke:Lua\\|invoke\\|module=Template\\|fn=stashArgs\\|namespace=LegacyTeamCard}}` \|


		Before invoking the TP render, the wrapper also sets two global page vars from the first non-TBD card (matching old TC behavior): `team` (resolved team name at `tournament_date`) and `teamRR` (redirect-resolved name). TP's `setPageVars` does the per-team `<TeamName>_pN` style vars itself, so those are not duplicated here.

		If the first stash entry contains a `team` key (i.e. it looks like a card, not a header — defensive case for pages where `columns start` is missing or malformed), treat all entries as cards and synthesize an empty header.

		\| `image1`/`imagedark1`/`imagesize` \| dropped \| TP gets logos from team templates. Image override (#7295) was reverted (#7449). \|
		\| `flag` (header flag) \| dropped \| No TP equivalent. \|

		\| `notes` \| appended to `notes` list as `{text=notes, highlighted=false}` \| \|
		\| `inotes` \| appended to `notes` list as `{text=inotes, highlighted=false}` \| If both `notes` and `inotes` are set, both entries are added to the TP `notes` list. \|

		\| `pNdnp` (truthy) \| `played = false` \| `dnp` wins over `played`/`result` if both set. \|
		\| `pNplayed` / `pNresult` \| `played` (boolean) \| \|

		\| `c1` (default) \| `role = head coach` \| First coach is head coach. Override via per-wiki `coachRoles` config (Section 7). \|
		\| `c2..cN` (default) \| `role = coach` \| Override via per-wiki `coachRoles` config. \|


		Coach mapping (per `cN`, `scN`, `fcN`, `t2cN`, `t3cN`):

		\| TC param \| TP `Person` field \| Notes \|


		## Out of scope

		- Per-wiki bot-edit work to insert `{{TeamCard columns start}}` / `{{TeamCard columns end}}` around naked `{{TeamCard}}` runs. The wrapper assumes columns markers are always present.

Conversation

Eetwalt commented May 7, 2026

Summary

How did you test this change?

Uh oh!

Rathoz May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rathoz May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rathoz May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rathoz May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rathoz May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rathoz May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hjpalpha left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Rathoz May 7, 2026 •

edited

Loading

Rathoz May 7, 2026 •

edited

Loading

Rathoz May 7, 2026 •

edited

Loading

Rathoz May 7, 2026 •

edited

Loading

Rathoz May 7, 2026 •

edited

Loading

Rathoz May 7, 2026 •

edited

Loading