added download task publishers #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
schrockblock
left a comment
schrockblock
left a comment
There was a problem hiding this comment.
Couple of suggestions
| var responseHandler: (URLResponse?) -> Void { get set } | ||
| var httpResponseHandler: (HTTPURLResponse) -> Void { get set } | ||
| var dataHandler: (Data?) -> Void { get set } | ||
| var urlHandler: (URL?) -> Void { get set } |
Collaborator
There was a problem hiding this comment.
Is this the URL to the file on the system? If so, I think we need a clearer name, I though this was the request URL for like 10m
| dataTask?.resume() | ||
| call.responder?.taskHandler(dataTask) | ||
| call.responder?.taskHandler(dataTask as? URLSessionDataTask) | ||
| call.responder?.downloadTaskHandler(dataTask as? URLSessionDownloadTask) |
Collaborator
There was a problem hiding this comment.
I think we should only send one of these each time, not both
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.