Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds from Shilpa's branch for the inputField component and implements @MelisaIm's feedback from PR #24:
adds placeholder prop to align with design spec
adds isEmail boolean to verify email field input is an email
adds an onSubmit() for email validation and provides errror messaging should an input not be valid; passing via onSubmitEditing prop to component so parent can pass more specific actions onSubmit
adds validation prop to component so that more specific validation can come from parent component (ie phone number)
add sanitizing logic to the input on the onChange() to process before storing (removes whitespace or trailing spaces, escapes special characters, and replaces null characters)
adds tests for the inputField component