delara/eng-990-fe-employees-list#243
Open
Mittensdlara wants to merge 3 commits intodevfrom
Open
Conversation
ENG-990 🐛 [FE] employees list
🐞 Bug description: When an owner invite an
there is need to a change use effect in 🧪 How to reproduce it?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
remove the second parameter in
useEEfect. This will ensure that the employees list is only updated when thegetEmployeesfunction is called, and not every time the employees state changes.Fixes # (issue id from leantime)
Type of change
How Has This Been Tested?
Has been tasted by send an invitation for an employee and see if it works.
Checklist: