Skip to content

delara/eng-990-fe-employees-list#243

Open
Mittensdlara wants to merge 3 commits intodevfrom
delara/eng-990-fe-employees-list
Open

delara/eng-990-fe-employees-list#243
Mittensdlara wants to merge 3 commits intodevfrom
delara/eng-990-fe-employees-list

Conversation

@Mittensdlara
Copy link
Copy Markdown
Collaborator

Description

remove the second parameter in useEEfect . This will ensure that the employees list is only updated when the getEmployees function is called, and not every time the employees state changes.

Fixes # (issue id from leantime)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Has been tasted by send an invitation for an employee and see if it works.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@linear
Copy link
Copy Markdown

linear Bot commented Feb 21, 2023

ENG-990 🐛 [FE] employees list

🐞 Bug description:

When an owner invite an emplyee the list of employees need to be update after sending the activationEmail, so there is need to add getAllEmployee function in this path:

src/pages/invite.tsx

there is need to a change use effect in src/pages/employees/index.tsx the array should be empty .

🧪 How to reproduce it?

  1. When the owner add an employee at first owner could not access to employee list, there is need to refresh the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant