feat: create "identity" field for Site and update endpoints accordingly #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two new API endpoints for site management: - /api/secure-site with POST, PUT, and DELETE operations for authenticated site management - /api/public-sites with GET operation to retrieve public sites list Regenerated schema.d.ts using make build-typescript to include TypeScript definitions for the new endpoints and their request/response types.
add mongoose schema to represent Site. includes support for required fields such as name, coordinates, status, address, and cell_id, as well as optional fields like color and boundary with validation.
- Add POST /api/secure-site to create new sites - Add PUT /api/secure-site to update existing sites - Add DELETE /api/secure-site to remove sites
Routes were missing leading slash causing 404 errors for /api/secure-site
Create /api/public-sites GET route that returns list of sites
Apply suggested changes from code review
Update public sites endpoint name to /api/sites
…changes to ensure compatability
- Create secure-site.test.ts to test all the functions in secure-site.ts with exhaustive cases - Update package.json to include an "npm run test" script to run tests - Change secure-site.ts to use event handlers for ease of testing
Collaborator
|
One thing, use a more descriptive branch name for each PR. This will help tell the work quickly :) |
johnnzhou
reviewed
Oct 31, 2025
johnnzhou
reviewed
Oct 31, 2025
src/routes/secure-site.ts
Outdated
|
|
||
| // Generate identity using SHA256 hash | ||
| const skpk = siteData.name; | ||
| const identity = crypto.createHash('sha256').update(skpk).digest('hex'); |
Collaborator
There was a problem hiding this comment.
Why the identity is generated from skpk
Collaborator
Author
There was a problem hiding this comment.
I just copied what was being done for User, I changed it to reflect the name correctly.
Collaborator
There was a problem hiding this comment.
I don't think this is correct. Site identity should not have any association with private key
Collaborator
|
Can you also briefly describe the new design in the comment section? |
Collaborator
|
Can you move this to the description section at the top? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially, I added an additional "identity" field to uniquely identify Sites that is generated each time a new site is created
![Uploading Database.png…]()