Conversation
forgot to include in other commit
imported from micro library
nightwatch uses different block tag names like method and api
fixes the node:events:353 error but generates new error (progress!)
causes errors
keeps the url predictable
resolves chromedriver errors
remove hard coded urls to global vars and remove checks for data.
removes lt, chromedriver, request, selenium-webdriver
E-Rick
changed the title
tngzng
left a comment
tngzng
left a comment
There was a problem hiding this comment.
comments
looks good!
the two-step test for each module looks good for now (widget seen, widget clicked) and i'm excited to test out the github workflows in action
local testing
the command docker compose up -d fails for me with Error response from daemon: invalid mount config for type "bind": bind source path does not exist: /Users/ting/lnl/wp-content
do you mind updating the local testing steps in the pr description so i can try it out again?
suggestions
in the future, i might suggest submitting separate pr's at each of these steps if possible:
1 - direct copy of code from another repo (same goes for any scaffolding from a template)
2 - addition of new code
3 - addition of github action workflow config
we can chat more at our next one on one!
| matrix: | ||
| python-version: [3.8] |
There was a problem hiding this comment.
do we need to use the matrix strategy if we're not using multiple configuration options?
from the docs
You can specify a matrix by supplying an array for the configuration options. For example, if the runner supports Node.js versions 10, 12, and 14, you could specify an array of those versions in the matrix.
There was a problem hiding this comment.
Thanks, I added it at the time to be flexible, but you are right it makes more sense to only add what is needed.
I'll change it 🙌🏽
| matrix: | ||
| python-version: [3.8] | ||
|
|
||
| steps: |
| }, | ||
| { | ||
| "name": "Washington City Paper - Dev", | ||
| "priority": 9, |
There was a problem hiding this comment.
Enrichment process reads through each object depending on priority. Lower number = higher priority.
Priority Helps the schema resolver determine the lookup order for the schema repositories. See` Iglu Schema Resolution
| 'Testing micro received the expected "widget_seen" event with context' | ||
| ); | ||
| }, | ||
| 'Step 2: Number of good events after user CLICKS a RECENT POST is equal to TWO': async function ( |
There was a problem hiding this comment.
these descriptions are helpful. thanks!
2 participants
Changes proposed in this Pull Request:
Fixes the issues with running the Snowplow Micro test suite. Removed checks for schema data such as articleIds because of trouble with pulling the attributes async from the Nightwatch API.
This is moved over from Snowplow repo and requires you to install localtunnel globally right now because I haven't got it to work within the test suite yet. So it's a manual process of starting the tunnel in a separate terminal window to get the HTTPS going.
How to test the changes in this Pull Request:
npm install -g localtunneldocker compose up -dto start running the micro containerlt --port 9090 --subdomain lnlmicro --opento run the localtunnel server for httpsokayin the browsernightwatchto run the default envnightwatch -e prodto run prod testsOther information: