Skip to content

metadata.requested should be compared against exportRequestDuration #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hampelm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

metadata.requested should be compared against exportRequestDuration #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/controllers/responses.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,7 @@ function handleExport(req, res, type) {
var metadata = doc.exports[type];

// See when we kicked off the export. If it was a long time ago, then we need to kick off a background task.
if (metadata.requested < now - exportDuration) {
if (metadata.requested < now - exportRequestDuration) {
console.log(util.format('info at=export event=generate reason=stale_metadata request_time=%d now=%d export_duration=%d', metadata.requested, now, exportDuration));
generate();
return;
Expand Down Expand Up @@ -1021,6 +1021,7 @@ function handleExport(req, res, type) {

var lastModifiedText = head.headers['last-modified'];
var lastModified = new Date(lastModifiedText);

// If the file exists and is old, kick off a background task.
if (!lastModifiedText || lastModified < now - exportDuration || lastModified < metadata.requested) {
console.log(util.format('info at=export event=generate reason=stale_export export_time=%d now=%d export_duration=%d', lastModified, now, exportDuration));
Expand Down