Open
Conversation
SeddikKadi
force-pushed
the
admin-modal
branch
3 times, most recently
from
c08f63b to
b511043
Compare
SeddikKadi
force-pushed
the
admin-modal
branch
3 times, most recently
from
bcc198f to
7911b0c
Compare
SeddikKadi
force-pushed
the
admin-modal
branch
13 times, most recently
from
c14ea60 to
8687ddd
Compare
SeddikKadi
force-pushed
the
admin-modal
branch
8 times, most recently
from
1195cfa to
e8574b8
Compare
SeddikKadi
force-pushed
the
admin-modal
branch
3 times, most recently
from
eaafef9 to
240d772
Compare
SeddikKadi
force-pushed
the
admin-modal
branch
3 times, most recently
from
599a79d to
d0a5848
Compare
…n ``BankAccountItem`` wip
Replace scattered ``$modal.args?.value[0]`` accesses (~30 occurrences) with structured computed properties: - Base accessors: ``args``, ``type``, ``account``, ``transactions`` - Type guards: ``isTopUp``, ``isReconversion``, ``isTransactionDetail``, ``isPaymentConfirmation`` - Derived display: ``modalTitle``, ``statusTitle``, ``icon``, ``showTopUpActions``, ``topUpStatusMessage``, etc. This consolidates transaction-type switching logic from inline template conditionals into testable computed properties, improving readability and maintainability.
… ``string`` instead of ``Number``
Make ``QrCodeModal`` a pure display modal that receives ``title``, ``label``, ``name`` and ``data`` from the caller. Open ``QrCodeModal`` from ``MoneyRequestModal`` instead of maintaining a dedicated QR step, and cache ``account`` locally to avoid ``$modal.args`` reactivity issues when stacking modals. Update ``main.ts`` QR action to pass modal args instead of ``accountId``.
… recipient name when backend is present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.