Conversation
Summary of ChangesHello @Lokowitz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new dev-build target in the Makefile to facilitate building a local development Docker image. My review focuses on improving this new target. I've suggested marking the target as .PHONY in line with Makefile best practices and changing the Docker tag from :latest to :dev to prevent potential conflicts with release builds. These adjustments will enhance the reliability and clarity of the development process.
Makefile
Outdated
| go-build-release-windows-amd64: | ||
| CGO_ENABLED=0 GOOS=windows GOARCH=amd64 go build -o bin/olm_windows_amd64.exe | ||
|
|
||
| dev-build: |
There was a problem hiding this comment.
Makefile
Outdated
| CGO_ENABLED=0 GOOS=windows GOARCH=amd64 go build -o bin/olm_windows_amd64.exe | ||
|
|
||
| dev-build: | ||
| docker build -t fosrl/olm:latest . |
There was a problem hiding this comment.
Using the :latest tag for a development build can cause conflicts with the docker-build-release target, which also tags the image as :latest. This can lead to confusion or accidentally using a local development image instead of a production-ready one. It's recommended to use a specific tag for development, such as :dev.
docker build -t fosrl/olm:dev .
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
How to test?