Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 0 additions & 95 deletions GitOps/Jenkinsfile

This file was deleted.

37 changes: 20 additions & 17 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,36 +1,39 @@
version: "3.8"

services:
mysql:
mysql:
image: mysql:latest
container_name: mysql
ports:
- 3306:3306
environment:
- MYSQL_ROOT_PASSWORD=Test@123
- MYSQL_DATABASE=BankDB
MYSQL_ROOT_PASSWORD: "Test@123"
MYSQL_DATABASE: "BankDB"
Comment on lines +10 to +11
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Remove unnecessary quotes from environment variables.

The quotes around environment variable values are unnecessary and could cause issues:

-      MYSQL_ROOT_PASSWORD: "Test@123"
-      MYSQL_DATABASE: "BankDB"
+      MYSQL_ROOT_PASSWORD: Test@123
+      MYSQL_DATABASE: BankDB
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
MYSQL_ROOT_PASSWORD: "Test@123"
MYSQL_DATABASE: "BankDB"
MYSQL_ROOT_PASSWORD: Test@123
MYSQL_DATABASE: BankDB

networks:
- banknet
volumes:
- bankapp-volume:/var/lib/mysql
networks:
- bankapp
- mysqlvol:/var/lib/mysql
healthcheck:
test: ["CMD", "mysqladmin", "ping", "-h", "localhost"]
interval: 10s
timeout: 5s
retries: 3
start_period: 30s

mainapp:
image: ${DUSER}/${IMAGE}
container_name: Bankapp
environment:
- SPRING_DATASOURCE_USERNAME=root
- SPRING_DATASOURCE_URL=jdbc:mysql://mysql:3306/BankDB?useSSL=false&allowPublicKeyRetrieval=true&serverTimezone=UTC
- SPRING_DATASOURCE_PASSWORD=Test@123
bankapp:
container_name: bankapplication
image: sharmaaakash170/springboot-bank-app:latest
ports:
- "8080:8080"
environment:
- SPRING_DATASOURCE_USERNAME= "root"
- SPRING_DATASOURCE_URL= "jdbc:mysql://mysql:3306/BankDB?useSSL=false&allowPublicKeyRetrieval=true&serverTimezone=UTC"
- SPRING_DATASOURCE_PASSWORD= "Test@123"
Comment on lines +29 to +31
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix environment variable format and database name mismatch.

There are several issues with the environment variables:

  1. Unnecessary spaces after equal signs
  2. Unnecessary quotes
  3. Database name mismatch (BankDB vs bankappdb in application.properties)
-      - SPRING_DATASOURCE_USERNAME= "root"
-      - SPRING_DATASOURCE_URL= "jdbc:mysql://mysql:3306/BankDB?useSSL=false&allowPublicKeyRetrieval=true&serverTimezone=UTC"
-      - SPRING_DATASOURCE_PASSWORD= "Test@123"
+      - SPRING_DATASOURCE_USERNAME=root
+      - SPRING_DATASOURCE_URL=jdbc:mysql://mysql:3306/bankappdb?useSSL=false&allowPublicKeyRetrieval=true&serverTimezone=UTC
+      - SPRING_DATASOURCE_PASSWORD=Test@123
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- SPRING_DATASOURCE_USERNAME= "root"
- SPRING_DATASOURCE_URL= "jdbc:mysql://mysql:3306/BankDB?useSSL=false&allowPublicKeyRetrieval=true&serverTimezone=UTC"
- SPRING_DATASOURCE_PASSWORD= "Test@123"
- SPRING_DATASOURCE_USERNAME=root
- SPRING_DATASOURCE_URL=jdbc:mysql://mysql:3306/bankappdb?useSSL=false&allowPublicKeyRetrieval=true&serverTimezone=UTC
- SPRING_DATASOURCE_PASSWORD=Test@123

networks:
- banknet
depends_on:
mysql:
condition: service_healthy
networks:
- bankapp
restart: always
healthcheck:
test: ["CMD-SHELL", "curl -f http://localhost:8080/actuator/health || exit 1"]
Expand All @@ -40,7 +43,7 @@ services:
start_period: 30s

networks:
bankapp:
banknet:

volumes:
bankapp-volume:
mysqlvol:
49 changes: 0 additions & 49 deletions helm/README.md

This file was deleted.

24 changes: 0 additions & 24 deletions helm/bankapp/Chart.yaml

This file was deleted.

6 changes: 0 additions & 6 deletions helm/bankapp/templates/NOTES.txt

This file was deleted.

10 changes: 0 additions & 10 deletions helm/bankapp/templates/configMap.yml

This file was deleted.

61 changes: 0 additions & 61 deletions helm/bankapp/templates/deployment.yml

This file was deleted.

19 changes: 0 additions & 19 deletions helm/bankapp/templates/hpa.yaml

This file was deleted.

20 changes: 0 additions & 20 deletions helm/bankapp/templates/ingress.yml

This file was deleted.

15 changes: 0 additions & 15 deletions helm/bankapp/templates/mysqlService.yml

This file was deleted.

Loading