Skip to content

Cicd #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mghaderi187 wants to merge 4 commits into
base: DevOps
Choose a base branch
from
Open

Cicd #19

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46f4eb6
Update docker-compose.yml
mghaderi187 Feb 11, 2025
3ddeb6a
Update docker-compose.yml
mghaderi187 Feb 11, 2025
e64eeca
Update docker-compose.yml
mghaderi187 Feb 11, 2025
e9c2541
Update docker-compose.yml
mghaderi187 Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,15 @@ services:
start_period: 30s

mainapp:
image: ${DUSER}/${IMAGE}
build:
context: .
Comment on lines +21 to +22
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical YAML Indentation Error in Build Configuration.
The context: . line is not indented as a child of build:. In a valid YAML mapping for Docker Compose, context: should be nested two additional spaces under build:.
Please update the indentation as follows:

-    build:
-    context: .
+    build:
+      context: .
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
build:
context: .
build:
context: .

container_name: Bankapp
environment:
- SPRING_DATASOURCE_USERNAME=root
- SPRING_DATASOURCE_URL=jdbc:mysql://mysql:3306/BankDB?useSSL=false&allowPublicKeyRetrieval=true&serverTimezone=UTC
- SPRING_DATASOURCE_PASSWORD=Test@123
ports:
- "8080:8080"
- "8081:8080"
depends_on:
mysql:
condition: service_healthy
Expand All @@ -43,4 +44,4 @@ networks:
bankapp:

volumes:
bankapp-volume:
bankapp-volume: