Added Jenkinsfile & also jenkins output images stepwise #4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,36 @@ | ||||||||||||||||||||||||||||||||||||||||||||||||||
| pipeline { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| agent { label 'spring-server' } | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||
| stages { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| stage("Code Clone") { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| steps { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| echo "Code Clone Stage" | ||||||||||||||||||||||||||||||||||||||||||||||||||
| git url: "https://github.com/shailesh271997/Springboot-BankApp.git", branch: "nginx-setup" | ||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+5
to
+10
There was a problem hiding this comment. 🛠️ Refactor suggestion Improve Git checkout configuration. Several improvements are recommended for the Code Clone stage:
- stage("Code Clone") {
+ stage("Checkout") {
steps {
- echo "Code Clone Stage"
- git url: "https://github.com/shailesh271997/Springboot-BankApp.git", branch: "nginx-setup"
+ cleanWs()
+ checkout scm
}
}If you need to keep the explicit git step, consider using parameters: parameters {
string(name: 'BRANCH_NAME', defaultValue: 'nginx-setup', description: 'Git branch to build')
} |
||||||||||||||||||||||||||||||||||||||||||||||||||
| stage("Code Build & Test") { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| steps { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| echo "Code Build Stage" | ||||||||||||||||||||||||||||||||||||||||||||||||||
| sh "docker build -t springboot-bankapp ." | ||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+11
to
+16
There was a problem hiding this comment. Enhance build stage with tests and proper versioning. The current build stage has several missing components:
stage("Code Build & Test") {
steps {
- echo "Code Build Stage"
- sh "docker build -t springboot-bankapp ."
+ script {
+ def version = env.BUILD_NUMBER
+ // Run tests
+ sh "./mvnw clean test"
+ // Build with proper tags and cache
+ sh """
+ docker build \
+ --cache-from springboot-bankapp:latest \
+ -t springboot-bankapp:${version} \
+ -t springboot-bankapp:latest \
+ --build-arg VERSION=${version} \
+ .
+ """
+ }
}
}📝 Committable suggestion
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||||||
| stage("Push To DockerHub") { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| steps { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| withCredentials([usernamePassword( | ||||||||||||||||||||||||||||||||||||||||||||||||||
| credentialsId: "dockerHubCreds", | ||||||||||||||||||||||||||||||||||||||||||||||||||
| usernameVariable: "dockerHubUser", | ||||||||||||||||||||||||||||||||||||||||||||||||||
| passwordVariable: "dockerHubPass")]) { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| sh 'echo $dockerHubPass | docker login -u $dockerHubUser --password-stdin' | ||||||||||||||||||||||||||||||||||||||||||||||||||
| sh "docker image tag springboot-bankapp ${env.dockerHubUser}/springboot-bankapp:latest" | ||||||||||||||||||||||||||||||||||||||||||||||||||
| sh "docker push ${env.dockerHubUser}/springboot-bankapp:latest" | ||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+17
to
+28
There was a problem hiding this comment. 🛠️ Refactor suggestion Add security scanning and error handling to Docker push stage. The current stage needs security and reliability improvements:
stage("Push To DockerHub") {
steps {
- withCredentials([usernamePassword(
- credentialsId: "dockerHubCreds",
- usernameVariable: "dockerHubUser",
- passwordVariable: "dockerHubPass")]) {
- sh 'echo $dockerHubPass | docker login -u $dockerHubUser --password-stdin'
- sh "docker image tag springboot-bankapp ${env.dockerHubUser}/springboot-bankapp:latest"
- sh "docker push ${env.dockerHubUser}/springboot-bankapp:latest"
+ script {
+ def version = env.BUILD_NUMBER
+ try {
+ // Scan for vulnerabilities
+ sh "trivy image springboot-bankapp:${version}"
+
+ withCredentials([usernamePassword(
+ credentialsId: "dockerHubCreds",
+ usernameVariable: "dockerHubUser",
+ passwordVariable: "dockerHubPass")]) {
+ sh '''
+ echo $dockerHubPass | docker login -u $dockerHubUser --password-stdin docker.io
+ docker image tag springboot-bankapp:${version} docker.io/${dockerHubUser}/springboot-bankapp:${version}
+ docker image tag springboot-bankapp:${version} docker.io/${dockerHubUser}/springboot-bankapp:latest
+ docker push docker.io/${dockerHubUser}/springboot-bankapp:${version}
+ docker push docker.io/${dockerHubUser}/springboot-bankapp:latest
+ '''
+ }
+ } catch (Exception e) {
+ error "Failed to push image: ${e.message}"
+ } finally {
+ sh 'docker logout'
+ // Clean up local images
+ sh "docker rmi springboot-bankapp:${version} || true"
+ }
}
}
}
|
||||||||||||||||||||||||||||||||||||||||||||||||||
| stage("Deploy") { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| steps { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| sh "docker compose down && docker compose up -d --build" | ||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+29
to
+33
There was a problem hiding this comment. Improve deployment reliability and add health checks. The current deployment strategy has several concerns:
stage("Deploy") {
steps {
- sh "docker compose down && docker compose up -d --build"
+ script {
+ try {
+ // Verify docker-compose.yml exists
+ sh '[ -f docker-compose.yml ] || (echo "docker-compose.yml not found" && exit 1)'
+
+ // Rolling update to avoid downtime
+ sh '''
+ docker compose pull
+ docker compose up -d --no-deps --build app
+
+ # Wait for health check
+ timeout 60s bash -c 'until curl -s http://localhost:8080/actuator/health | grep -q "UP"; do sleep 5; done'
+ '''
+ } catch (Exception e) {
+ echo "Deployment failed, rolling back..."
+ sh 'docker compose rollback app'
+ error "Failed to deploy: ${e.message}"
+ }
+ }
}
}
|
||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add timeout and resource constraints to the pipeline.
Consider adding pipeline-level timeout and resource constraints to prevent hung builds and resource exhaustion:
pipeline { agent { label 'spring-server' } + options { + timeout(time: 1, unit: 'HOURS') + } + resources { + memory '2048Mi' + cpu '500m' + }