fix: Improve code quality and state priority list screen#700
Merged
marwanqashwa merged 2 commits intodevelopfrom Aug 19, 2025
Merged
fix: Improve code quality and state priority list screen#700marwanqashwa merged 2 commits intodevelopfrom
marwanqashwa merged 2 commits intodevelopfrom
Conversation
marwanqashwa
requested review from
a team,
AbdoMagdey24,
Abdulrahman-Ragab-01,
Al-Taie,
AsmaaKhaledGomaa,
BassantM,
Mostafa-alsaygh,
aabukmail,
abdelrhman1002,
abdo-essam,
ahmeddsamii,
hassanwasfy,
karimdeabes and
yusufnasserdev
Contributor
|
[London Bot] Metrics Update Status 📊 PR metrics successfully updated for event: |
Contributor
|
[London Bot] Auto-update Status ✅ Branch successfully updated from |
Code Coverage Summary
|
yusufnasserdev
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ListViewModelfor better readability and organization by extracting logic into private functions and simplifying existing ones.handlePagingLoadingAutomaticallyparameter fromviewItemsScreen.ktas it's now handled by default inBuildScreen.kt.BuildScreen.ktto handle paging loading automatically by default and adjusted the order of conditional checks.CategoriesScreen.kt,listScreen.kt,SearchScreen.kt,HomeScreen.kt,AccountScreen.kt) using a newnavBarBottomPaddingmodifier extension.Type of Change
Changes Made