Feature: Bookmark Sheet Integration by yusufnasserdev · Pull Request #701 · LondonSquad/Novix

yusufnasserdev · 2025-08-19T20:21:54Z

Navigation Host Wrapping & Bookmark Sheet Integration

Summary

This PR introduces a comprehensive navigation host wrapping implementation and integrates the bookmark sheet functionality across multiple screens. The changes include architectural improvements, UI enhancements, and bug fixes to provide a consistent user experience for managing bookmarks throughout the application.

Key Changes

1. Navigation Host Wrapping

Replaced basic Scaffold with ScaffoldWithSnackbar in NavHostGraph.kt
Added snackbar controller composition local provider for global snackbar management
Enhanced navigation structure to support consistent UI patterns

2. Bookmark Sheet Integration

Integrated the bookmark bottom sheet across multiple screens:

Movie Category Screen - Added bookmark management for category movies
Movie Details Screen - Replaced simple save icon with full bookmark functionality
Continue Watching Screen - Added bookmark support for movies in continue watching
Top Rated Screen - Enabled bookmark management for top-rated content
Trending Movies Screen - Integrated bookmark functionality
Search Screen - Added bookmark support in search results and recent items

3. Architectural Improvements

Enhanced CustomMovieListRepository with better error handling and caching
Fixed API endpoint for account lists (GET_ACCOUNT_LISTS_PATH)
Added cache clearing on logout and sync metadata management
Improved data synchronization with periodic sync scheduling moved to MainActivity

4. UI/UX Enhancements

Consistent snackbar implementation across all screens
Improved empty states with better messaging for no lists available
Fixed localization issues in Arabic strings
Enhanced onboarding screen padding and insets handling

Technical Details

New Components

ScaffoldWithSnackbar: Wrapper component that provides snackbar functionality
LocalSnackbarController: Composition local for global snackbar access
BookmarkBottomSheet: Reusable component for managing bookmarks

Refactored Components

Media grid components now support conditional save icons
HomeCard component updated with hasSaveIcon parameter
Navigation handlers improved for better type safety

Bug Fixes

Fixed movie list synchronization on authentication changes
Resolved cache invalidation issues when adding/removing items
Fixed API path for account lists retrieval
Improved error handling throughout the bookmark flow

Impact

✅ Provides consistent bookmarking experience across all screens
✅ Improves navigation structure and UI consistency
✅ Enhances performance with better caching strategies
✅ Fixes several edge cases in list management
✅ Maintains backward compatibility with existing functionality

This implementation provides a solid foundation for the bookmarking system while maintaining the app's performance and user experience standards.

# Conflicts: # app/src/main/java/com/london/app/navigation/NavHostGraph.kt

- Implement a global snackbar using `ScaffoldWithSnackbar` and `SnackbarController` to display messages across the app. - Refactor movie list caching logic in `CustomMovieListRepositoryImpl` for improved efficiency and error handling. - Clear `SyncMetadataDao` cache on logout in `AuthenticationRepositoryImpl`. - Update `BookmarkSheet` to use the new global snackbar. - Adjust UI padding in `OnboardingScreen` for better system bar handling. - Modify "no lists available" string for clarity. - Ensure `MovieListSyncWorker` is scheduled in `MainActivity`.

…positoryImpl

…atching screens

# Conflicts: # data/src/main/java/com/london/data/remote/service/list/CustomMovieListsApiService.kt # data/src/main/java/com/london/data/repository/list/CustomMovieListRepositoryImpl.kt # presentation/src/main/java/com/london/presentation/feature/search/SearchScreen.kt

# Conflicts: # app/src/main/java/com/london/app/navigation/graph/mainNavGraph.kt

london-bot · 2025-08-19T20:22:14Z

[London Bot] Metrics Update Status

❌ An error occurred while updating PR metrics.

london-bot · 2025-08-19T20:22:43Z

[London Bot] Auto-update Status

✅ Branch successfully updated from develop.

…toryImpl

...src/main/java/com/london/data/local/source/customLists/CustomMovieListLocalDataSourceImpl.kt

data/src/main/java/com/london/data/repository/list/CustomMovieListRepositoryImpl.kt

…d refine test names

BassantM

it was not clickable in actor details screen

data/src/main/java/com/london/data/repository/list/CustomMovieListRepositoryImpl.kt

marwanqashwa

great job

app/src/main/java/com/london/app/NovixApplication.kt

app/src/main/java/com/london/app/navigation/NavHostGraph.kt

designSystem/src/main/java/com/london/designsystem/snackbar/ScaffoldWithSnackbar.kt

presentation/src/main/java/com/london/presentation/feature/home/toprated/TopRatedScreen.kt

presentation/src/main/java/com/london/presentation/feature/home/toprated/TopRatedViewModel.kt

...src/main/java/com/london/presentation/feature/home/trending/movie/TrendingMoviesViewModel.kt

presentation/src/main/java/com/london/presentation/feature/search/SearchViewModel.kt

...ntation/src/main/java/com/london/presentation/shared/bookmarkSheet/BookmarkSheetViewModel.kt

data/src/main/java/com/london/data/remote/model/ApiConstants.kt

designSystem/src/main/java/com/london/designsystem/snackbar/LocalSnackbarController.kt

presentation/src/main/java/com/london/presentation/feature/details/movie/MovieDetailsScreen.kt

github-actions · 2025-08-19T22:41:16Z

Code Coverage Summary

File	Coverage [44.92%]	❌
data/src/main/java/com/london/data/repository/authentication/AuthenticationRepositoryImpl.kt	100.00%	✅
data/src/main/java/com/london/data/repository/list/CustomMovieListRepositoryImpl.kt	51.75%	❌
presentation/src/main/java/com/london/presentation/feature/category/movie/MovieCategoryViewModel.kt	62.86%	❌
presentation/src/main/java/com/london/presentation/feature/details/actor/ActorDetailsViewModel.kt	72.55%	❌
presentation/src/main/java/com/london/presentation/feature/details/actor/info/topmoviespicks/TopMoviesPicksViewModel.kt	56.00%	❌
presentation/src/main/java/com/london/presentation/feature/details/actor/info/toptvshowspicks/TopTvShowsPicksViewModel.kt	83.33%	✅
presentation/src/main/java/com/london/presentation/feature/details/movie/MovieDetailsViewModel.kt	77.31%	❌
presentation/src/main/java/com/london/presentation/feature/home/continuewatching/ContinueWatchingViewModel.kt	78.72%	❌
presentation/src/main/java/com/london/presentation/feature/home/toprated/TopRatedViewModel.kt	0.00%	❌
presentation/src/main/java/com/london/presentation/feature/home/trending/movie/TrendingMoviesViewModel.kt	68.42%	❌
presentation/src/main/java/com/london/presentation/feature/search/SearchViewModel.kt	0.00%	❌
presentation/src/main/java/com/london/presentation/shared/bookmarkSheet/BookmarkSheetViewModel.kt	0.00%	❌

Total Project Coverage	59.82%	❌

yusufnasserdev added 12 commits August 18, 2025 19:33

feat: Implement custom Snackbar component

2434a04

Merge branch 'develop' into feature/snackbar-host

19917db

# Conflicts: # app/src/main/java/com/london/app/navigation/NavHostGraph.kt

Merge branch 'develop' into feature/snackbar-host

8d4daf3

refactor: improve readability and error handling in CustomMovieListRe…

26d9f7a

…positoryImpl

feat: implement bookmark bottom sheet for movies

4585fba

feat: integrate BookmarkBottomSheet into TrendingMovies and ContinueW…

0900e6a

…atching screens

feat: Implement bookmark functionality in TopRated screen

cdfb99f

feat: implement bookmark bottom sheet functionality

0da91b6

feat: integrate bookmark bottom sheet into movie category screen

93525bf

Merge branch 'develop' into feature/snackbar-host

3241527

# Conflicts: # app/src/main/java/com/london/app/navigation/graph/mainNavGraph.kt

yusufnasserdev self-assigned this Aug 19, 2025

yusufnasserdev requested review from a team August 19, 2025 20:22

yusufnasserdev added 3 commits August 19, 2025 23:32

refactor: pass CustomMovieListLocalDataSource to AuthenticationReposi…

4f53f66

…toryImpl

feat: clear all cache before caching movie lists and memberships

2b8fee5

refactor: remove save tv show functionality

11619ef

marwanqashwa self-requested a review August 19, 2025 21:37

marwanqashwa reviewed Aug 19, 2025

View reviewed changes

test: update CustomMovieListRepositoryImplTest to use assertThrows an…

2be2964

…d refine test names

BassantM reviewed Aug 19, 2025

View reviewed changes

feat: Implement bookmark functionality in TopMoviesPicks

26919eb

marwanqashwa reviewed Aug 19, 2025

View reviewed changes

feat: pass movieId to onManageBookmarkClicked

1c37b27

BassantM reviewed Aug 19, 2025

View reviewed changes

feat: Add bookmark functionality to actor details screen

e3543e4

Refactor: Standardize SnackBar and contract naming

35b8e7c

Abdulrahman-Ragab-01 approved these changes Aug 19, 2025

View reviewed changes

marwanqashwa approved these changes Aug 19, 2025

View reviewed changes

yusufnasserdev merged commit 2253ef3 into develop Aug 19, 2025
14 of 20 checks passed

yusufnasserdev deleted the feature/snackbar-host branch August 19, 2025 23:59

yusufnasserdev mentioned this pull request Aug 20, 2025

extra padding in the top of onBoarding screen #675

Closed

Conversation

yusufnasserdev commented Aug 19, 2025

Navigation Host Wrapping & Bookmark Sheet Integration

Summary

Key Changes

1. Navigation Host Wrapping

2. Bookmark Sheet Integration

3. Architectural Improvements

4. UI/UX Enhancements

Technical Details

New Components

Refactored Components

Bug Fixes

Impact

Uh oh!

london-bot bot commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

london-bot bot commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BassantM left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marwanqashwa left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

london-bot bot commented Aug 19, 2025 •

edited

Loading

london-bot bot commented Aug 19, 2025 •

edited

Loading

marwanqashwa left a comment •

edited

Loading

github-actions bot commented Aug 19, 2025 •

edited

Loading