Skip to content

make functions private and delete unused functions#702

Merged
Abdulrahman-Ragab-01 merged 14 commits intodevelopfrom
refactor/reformating
Aug 20, 2025
Merged

make functions private and delete unused functions#702
Abdulrahman-Ragab-01 merged 14 commits intodevelopfrom
refactor/reformating

Conversation

@Abdulrahman-Ragab-01
Copy link
Contributor

What does this PR do?

make functions private, delete unused functions, clean and reformate the files

Type of Change

  • 🔧 Refactoring

@london-bot
Copy link
Contributor

london-bot bot commented Aug 19, 2025

[London Bot] Metrics Update Status

📊 PR metrics successfully updated for event: closed.

@london-bot
Copy link
Contributor

london-bot bot commented Aug 19, 2025

[London Bot] Auto-update Status

✅ Branch successfully updated from develop.

@Abdulrahman-Ragab-01 Abdulrahman-Ragab-01 enabled auto-merge (squash) August 19, 2025 23:08
yusufnasserdev and others added 7 commits August 20, 2025 02:45
This commit renames the following files to use PascalCase for consistency:
- `notLoggedInContent.kt` to `NotLoggedInContent.kt`
- `userProfileSection.kt` to `UserProfileSection.kt`
- `accountMenuItem.kt` to `AccountMenuItem.kt`
- `loggedInContent.kt` to `LoggedInContent.kt`
@Abdulrahman-Ragab-01 Abdulrahman-Ragab-01 self-assigned this Aug 20, 2025
# Conflicts:
#	app/src/main/java/com/london/app/NovixApplication.kt
#	app/src/main/java/com/london/app/navigation/graph/mainNavGraph.kt
#	data/src/main/java/com/london/data/repository/list/CustomMovieListRepositoryImpl.kt
#	domain/src/main/java/com/london/domain/repository/CustomMovieListRepository.kt
#	presentation/src/main/java/com/london/presentation/feature/details/actor/ActorDetailsScreen.kt
#	presentation/src/main/java/com/london/presentation/feature/details/actor/ActorDetailsViewModel.kt
#	presentation/src/main/java/com/london/presentation/feature/details/actor/info/topmoviespicks/TopMoviesPicksContract.kt
#	presentation/src/main/java/com/london/presentation/feature/details/movie/MovieDetailsContract.kt
#	presentation/src/main/java/com/london/presentation/feature/details/movie/MovieDetailsUiState.kt
#	presentation/src/main/java/com/london/presentation/feature/home/toprated/TopRatedContract.kt
#	presentation/src/main/java/com/london/presentation/feature/home/toprated/TopRatedScreen.kt
#	presentation/src/main/java/com/london/presentation/feature/home/trending/movie/TrendingMoviesContract.kt
#	presentation/src/main/java/com/london/presentation/feature/home/trending/movie/TrendingMoviesViewModel.kt
#	presentation/src/main/java/com/london/presentation/feature/search/SearchViewModel.kt
#	presentation/src/main/java/com/london/presentation/shared/bookmarkSheet/BookmarkSheet.kt
@github-actions
Copy link

github-actions bot commented Aug 20, 2025

Code Coverage Summary

File Coverage [73.20%]
data/src/main/java/com/london/data/repository/account/AccountRepositoryImpl.kt 100.00%
data/src/main/java/com/london/data/repository/actor/ActorRepositoryImpl.kt 100.00%
data/src/main/java/com/london/data/repository/authentication/AuthenticationRepositoryImpl.kt 100.00%
data/src/main/java/com/london/data/repository/movie/MovieRepositoryImpl.kt 94.78%
data/src/main/java/com/london/data/repository/recent/RecentSearchRepositoryImpl.kt 100.00%
data/src/main/java/com/london/data/repository/recent/RecentViewedRepositoryImpl.kt 100.00%
data/src/main/java/com/london/data/repository/recent/RecentWatchedRepositoryImpl.kt 100.00%
data/src/main/java/com/london/data/repository/search/SearchRepositoryImpl.kt 56.60%
data/src/main/java/com/london/data/repository/tvshow/TvShowRepositoryImpl.kt 100.00%
domain/src/main/java/com/london/domain/usecase/authentication/AuthenticationUseCase.kt 100.00%
domain/src/main/java/com/london/domain/usecase/details/actor/GetActorUseCase.kt 100.00%
domain/src/main/java/com/london/domain/usecase/movielist/GetMovieListNameUseCase.kt 100.00%
domain/src/main/java/com/london/domain/usecase/movielist/IsMovieListedUseCase.kt 0.00%
domain/src/main/java/com/london/domain/usecase/movielist/ManageGetMovieUseCase.kt 75.00%
domain/src/main/java/com/london/domain/usecase/recent/viewed/ManageRecentViewedUseCase.kt 100.00%
domain/src/main/java/com/london/domain/usecase/search/ManageSearchUseCase.kt 100.00%
presentation/src/main/java/com/london/presentation/feature/account/AccountViewModel.kt 82.72%
presentation/src/main/java/com/london/presentation/feature/account/rating/MyRatingViewModel.kt 97.92%
presentation/src/main/java/com/london/presentation/feature/authentication/login/LoginViewModel.kt 54.55%
presentation/src/main/java/com/london/presentation/feature/authentication/register/RegistrationViewModel.kt 96.55%
presentation/src/main/java/com/london/presentation/feature/category/main/CategoriesViewModel.kt 100.00%
presentation/src/main/java/com/london/presentation/feature/category/movie/MovieCategoryViewModel.kt 62.86%
presentation/src/main/java/com/london/presentation/feature/category/tvshow/TvShowCategoryViewModel.kt 81.48%
presentation/src/main/java/com/london/presentation/feature/details/actor/ActorDetailsViewModel.kt 72.55%
presentation/src/main/java/com/london/presentation/feature/details/actor/info/gallery/ActorsGalleryViewModel.kt 81.25%
presentation/src/main/java/com/london/presentation/feature/details/actor/info/topmoviespicks/TopMoviesPicksViewModel.kt 56.00%
presentation/src/main/java/com/london/presentation/feature/details/actor/info/toptvshowspicks/TopTvShowsPicksViewModel.kt 83.33%
presentation/src/main/java/com/london/presentation/feature/details/movie/MovieDetailsViewModel.kt 77.31%
presentation/src/main/java/com/london/presentation/feature/details/tvshow/episode/EpisodeDetailsViewModel.kt 0.00%
presentation/src/main/java/com/london/presentation/feature/home/HomeViewModel.kt 75.00%
presentation/src/main/java/com/london/presentation/feature/home/continuewatching/ContinueWatchingViewModel.kt 78.72%
presentation/src/main/java/com/london/presentation/feature/home/toprated/TopRatedViewModel.kt 0.00%
presentation/src/main/java/com/london/presentation/feature/home/trending/actor/TrendingActorsViewModel.kt 80.00%
presentation/src/main/java/com/london/presentation/feature/home/trending/movie/TrendingMoviesViewModel.kt 68.42%
presentation/src/main/java/com/london/presentation/feature/home/trending/tvshow/TrendingTvShowsViewModel.kt 86.21%
Total Project Coverage 59.57%

@Abdulrahman-Ragab-01 Abdulrahman-Ragab-01 merged commit 92406da into develop Aug 20, 2025
11 of 12 checks passed
@Abdulrahman-Ragab-01 Abdulrahman-Ragab-01 deleted the refactor/reformating branch August 20, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants