Refactor delete old composable#717
Merged
AsmaaKhaledGomaa merged 29 commits intodevelopfrom Aug 20, 2025
Merged
Conversation
…d-composable # Conflicts: # presentation/src/main/java/com/london/presentation/feature/account/rating/MyRatingScreen.kt # presentation/src/main/java/com/london/presentation/feature/category/movie/MovieCategoryScreen.kt # presentation/src/main/java/com/london/presentation/feature/details/actor/info/topmoviespicks/TopMoviesPicksScreen.kt # presentation/src/main/java/com/london/presentation/feature/details/actor/info/toptvshowspicks/TopTvShowsPicksScreen.kt # presentation/src/main/java/com/london/presentation/feature/home/continuewatching/ContinueWatchingScreen.kt # presentation/src/main/java/com/london/presentation/feature/home/trending/actor/TrendingActorsScreen.kt # presentation/src/main/java/com/london/presentation/feature/search/SearchScreen.kt
…d-composable # Conflicts: # presentation/src/main/java/com/london/presentation/feature/home/trending/actor/TrendingActorsScreen.kt # presentation/src/main/java/com/london/presentation/feature/home/trending/movie/TrendingMoviesScreen.kt # presentation/src/main/java/com/london/presentation/feature/home/trending/tvshow/TrendingTvShowsScreen.kt # presentation/src/main/java/com/london/presentation/shared/MediaLazyPagingGrid.kt
Contributor
|
[London Bot] Metrics Update Status 📊 PR metrics successfully updated for event: |
Contributor
|
[London Bot] Auto-update Status ✅ Branch successfully updated from |
Code Coverage Summary
|
Abdulrahman-Ragab-01
previously approved these changes
Aug 20, 2025
…into refactor/delete-old-composable
BassantM
requested review from
BassantM
and removed request for
Abdulrahman-Ragab-01
BassantM
approved these changes
Aug 20, 2025
aabukmail
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This PR refactors the navigation parameter names across the app to follow a consistent and standardized naming convention, and removes old/unused composables to clean up the codebase.
Key Changes
composableusages with the updated standardized versions inmainNavGraph.kt:onNavigateToMovieDetailsonNavigateBackonNavigateToTvShowDetailsonNavigateToActorDetailsMediaLazyGridMediaLazyPagingGridMoviesLayOutTvShowLayOutWhy
MediaLazyGrid,MediaLazyPagingGrid,MoviesLayOut,TvShowLayOut) to simplify the codebase.